Standardize how we connect to the DB

Open
#1,091 2 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
38/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
python, sqlalchemy
Domain
backend, databases

Research direction

Start with 8Knot/cache_manager/cache_facade.py, especially lines 60–75, and read the earlier discussion about using SQLAlchemy to understand the intended connection pattern. Compare the current manual connection handling with that goal and identify what behavior must be preserved. Done means the database connection approach is standardized as agreed; the issue does not specify performance criteria.

Written by the indexing model from the issue text.

Description

technical debt

From previous discussions it sounds like our goal is to use sqlalchemy to connect to the DB, but here, in this file, we dont even import sqlalchemy and seem to be using lower level objects/handling connections manually:

https://github.com/oss-aspen/8Knot/blob/291d6fdf28d5263df304adaf836f6dce1890421a/8Knot/cache_manager/cache_facade.py#L60-L75

This may be an efficiency gain that could help us with performance (but in a way that i cant prove so maybe this souldnt be labeled that way)

Dominant language
Python
Stars
80
Forks
92
Avg merge
1d 11h
Merged PRs (30d)
13

Getting set up

  • Ships a Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from chaoss/8Knot

All issues in chaoss/8Knot

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.