Confirm we are correctly handling termination signals like SIGTERM

Open
#1,071 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
43/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
backend

Research direction

Start by locating how 8Knot handles process signals and shutdown, then trace the path used when Podman sends SIGTERM. Check whether the process completes a graceful shutdown before the runtime timeout; done means SIGTERM is handled and shutdown no longer requires SIGKILL in this scenario.

Written by the indexing model from the issue text.

Description

infrastructure

i see this when ctrl-c ing 8knot in podman:

WARN[0010] StopSignal SIGTERM failed to stop container 8knot_redis-users_1 in 10 seconds, resorting to SIGKILL 

Augur has a similar issue where its not listening to the SIGTERM (polite shutdown request) signal from linux, causing the container runtimes timeout to be hit and for it to be sent the SIGKILL (the process is being terminated) signal.

We should check how we handle these signals and make sure it can handle both so that things are shut down gracefully more often.

Dominant language
Python
Stars
80
Forks
92
Avg merge
1d 11h
Merged PRs (30d)
13

Getting set up

  • Ships a Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from chaoss/8Knot

All issues in chaoss/8Knot

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.