Relative-to-eye placement of far things, and the view as the instrument sees it (option 3)
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- javascript, three.js
- Domain
- computer-graphics
Research direction
Start with HDR.md sections “A telescope’s field” and “The instrument,” then inspect the far-point and star rendering paths the issue says already apply the instrument response. The issue gives no file or test names for the relative-to-eye renderer or resolved-disc pass, so first trace those entry points and the dependencies on #337 and #338. Done means far bodies and their paths render at the stated precision, and the instrument view can be toggled and compared at its resolution.
Written by the indexing model from the issue text.
Description
Part of #334, option 3: the general fix, as an override once options 1 and 2 are in (the maintainer's comment), and the ground for comparing an instrument's view with a spacecraft's photograph (Rubin on Saturn against Cassini's; #333 for Rubin's own imagery).
The precision. Everything placed at 7e12 m from the camera is held to float32's 5e5 m: the far body's mesh, the apparent path's points and its ring, the orbit line's vertices, and the body's depth, which reads as empty sky. Relative-to-eye rendering keeps each far thing's centre in float64 on the CPU and uploads, each frame, its offset from the camera and its geometry about its own centre, so the GPU never sees a large number. Three's scene graph is float32 at the matrix level, so this is per object: a far body's mesh at the camera's origin with a per-frame offset, the path's and orbit line's points as offsets from a float64 anchor near the camera's line of sight, and the depth of a far body written as a near-plane proxy so lines in front of it occlude.
The view as seen. The maintainer's wider ask: carry the render to the eye as the instrument would see it, and be able to toggle between that and the scene as drawn, so a telescope on a body we have spacecraft photographs of (Saturn, Jupiter) can be compared with them at the instrument's resolution. That is the instrument's PSF and pixel grid applied to the frame (HDR.md, "A telescope's field", "The instrument"), which the far point and the stars already do point by point; a resolved disc needs it as a pass.
Scope this after #337 and #338 land, and before or with #333.
- Dominant language
- JavaScript
- Stars
- 55
- Forks
- 4
- Avg merge
- 10h 12m
- Merged PRs (30d)
- 134
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from celestiary/web
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
celestiary/web#345 ·
Maintainers usually reply within 1 day
-
Cesium guest (?cesium=iframe): white flicker near Mars's and Earth's surface remains after #335Open
Difficulty 4/5 3-5 days Newbie friendliness 35/100
celestiary/web#344 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 1-2 days Newbie friendliness 48/100
celestiary/web#336 ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
celestiary/web#334 · 1 comment ·
Maintainers usually reply within 1 day
-
enhancement track:spacecraft
Difficulty 5/5 Over a week Newbie friendliness 28/100
celestiary/web#333 · 1 comment ·
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
-
tech-debt
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
srikanth235/centraid#1155 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
microsoft/monaco-editor#5563 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day