Unblock the disabled node-addon-examples (lambdas, `noexcept`, output paths)
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 55/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Domain
- build-system, tooling
Research direction
Start with packages/node-addon-examples/scripts/copy-examples.mts and reproduce one disabled lambda example to capture the compiler error. Then inspect the gyp-to-cmake translation and output paths for the noexcept and require-path cases. Done means the three blockers are resolved independently and the affected examples can be enabled and built with their expected paths.
Written by the indexing model from the issue text.
Description
packages/node-addon-examples/scripts/copy-examples.mts carries a list of upstream examples we deliberately skip. Most entries are disabled for reasons we accept and won't fix (they use worker_threads, process.argv, node:events, uv.h, or bring their own CMake project). Five carry TODOs instead — i.e. we intend to enable them:
https://github.com/callstackincubator/react-native-node-api/blob/29a527d87fa8cb965b0048b1b4c1cff2b0eab281/packages/node-addon-examples/scripts/copy-examples.mts#L19-L28
https://github.com/callstackincubator/react-native-node-api/blob/29a527d87fa8cb965b0048b1b4c1cff2b0eab281/packages/node-addon-examples/scripts/copy-examples.mts#L38-L40
Three distinct blockers:
- Lambda functions — blocks
1-getting-started/6_object_wrap/napi/,1-getting-started/7_factory_wrap/napi/and2-js-to-native-conversion/8_passing_wrapped/napi/. Three examples for one fix, so this is the highest-value of the three. noexcept— blocks2-js-to-native-conversion/object-template-demo/napi/.- Output-directory mismatch — as the
TODOnotes,gyp-to-cmakeshould produce projects whose output directory matches whatgypwould have produced, so that examples with arequirepointing at the conventional gyp path resolve. That would unblock5-async-work/napi-asyncworker-example/node-addon-api/and6-threadsafe-function/promise-callback-demo/node-addon-api/, both currently disabled with "require statement to an unexpected path".
The first two say "Fix C++ support", which is worth pinning down before anyone starts: it is not obvious from the comments whether the failure is in gyp-to-cmake's translation, in a C++ standard/flag we pass, or in the host's C++ surface. Reproducing one of the lambda cases and capturing the actual compiler error is the first step.
Each of the three can land independently. Related to the other gyp-to-cmake gaps: #98, #99, #100, #101, #102, #103.
- Dominant language
- TypeScript
- Stars
- 188
- Forks
- 10
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 3
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from callstackincubator/react-native-node-api
-
Android 🤖
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
-
Sanity check of Hermes source directory via environment variable, when building Android projects OpenAndroid 🤖 good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
callstackincubator/react-native-node-api#163 · 1 comment ·
-
enhancement good first issue gyp-to-cmake
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
callstackincubator/react-native-node-api#161 · 3 comments · 1 reaction ·
-
enhancement Host 🏡
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
Automatable good first issue
Difficulty 3/5 1-2 days Newbie friendliness 15/100
callstackincubator/react-native-node-api#424 · 1 comment ·
All issues in callstackincubator/react-native-node-api
Similar issues
-
clawsweeper:linked-pr-open clawsweeper:no-new-fix-pr clawsweeper:source-repro impact:message-loss issue-rating: 🦞 diamond lobster maturity:stable P2
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Eynzof/Hermes-CN-Desktop#616 ·
-
ZCode 3.14.3 に対応する Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
supermomonga/zcode-acp#24 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
growthbook/growthbook#7100 ·
-
triage
Difficulty 1/5 1-3 hours Newbie friendliness 88/100