Sanity check of Hermes source directory via environment variable, when building Android projects
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
- Issue type
- Feature
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- android, react-native
- Domain
- build-system, mobile
Research direction
Start in packages/host/android/build.gradle around lines 141-157 and inspect how the Android build tasks are configured. Run an Android build without REACT_NATIVE_OVERRIDE_HERMES_DIR, then verify that it exits early with instructions using the provided npx react-native-node-api vendor-hermes command when the variable is missing.
Written by the indexing model from the issue text.
Description
I've investigated ways of letting the host package drive building Hermes from (our) source. So far, I haven't found any.
In the absence of a fully automated solution, it would be good if we exist early with instructions on how to set the REACT_NATIVE_OVERRIDE_HERMES_DIR environment variable if missing:
export REACT_NATIVE_OVERRIDE_HERMES_DIR=`npx react-native-node-api vendor-hermes --silent`
I would expect the error to be thrown from a new task around here:
- Dominant language
- TypeScript
- Stars
- 188
- Forks
- 10
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 3
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from callstackincubator/react-native-node-api
-
Android 🤖
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
-
enhancement good first issue gyp-to-cmake
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
callstackincubator/react-native-node-api#161 · 3 comments · 1 reaction ·
-
enhancement Host 🏡
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
Automatable good first issue
Difficulty 3/5 1-2 days Newbie friendliness 15/100
callstackincubator/react-native-node-api#424 · 1 comment ·
-
gyp-to-cmake
Difficulty 4/5 3-5 days Newbie friendliness 55/100
callstackincubator/react-native-node-api#423 · 1 comment ·
All issues in callstackincubator/react-native-node-api
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
safetrustcr/dApp-SafeTrust#426 ·
-
area:workflow bug ready-for-agent
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
fil-donadoni/tolaria#4409 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Fission-AI/OpenSpec#1960 ·
-
Add dependabot Open
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
corsairdev/corsair#1764 ·