Remote install: lease is not renewed during artifact upload
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 55/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- android, ios, typescript
- Domain
- backend-api-design, cli, mobile-dev
Research direction
Start in src/cli/commands/connection-runtime.ts at allocateOrReuseLease, then trace prepareRemoteRequestArtifacts and uploadArtifact through src/daemon/upload*.ts and src/daemon/resumable-upload*.ts. Compare the lease lifecycle with src/daemon/lease-registry-scope.ts and src/daemon/resumable-upload.ts; done means an upload exceeding the lease TTL can still reach a successful install RPC.
Written by the indexing model from the issue text.
Description
Observed
agent-device install <449 MB .apk> --remote-config <profile> against a remote daemon (EAS Simulator Android session), with a profile that sets no leaseProvider, fails with UNAUTHORIZED: Lease is not active. Diagnostics show: lease_allocate with the default 60 s TTL, then a 1m47s artifact upload with no lease heartbeat, then the install RPC against the expired lease. A 30 MB iOS .app on the same path never hits it.
Cause (as read at efce352)
- The CLI heartbeats or allocates the lease once when the command starts (
src/cli/commands/connection-runtime.ts,allocateOrReuseLease). Nothing in the upload path (prepareRemoteRequestArtifacts/uploadArtifact,src/daemon/upload*.ts,src/daemon/resumable-upload*.ts) touches the lease. - The default connection policy sends no
ttlMs, so the daemon appliesDEFAULT_LEASE_TTL_MS = 60_000(src/daemon/lease-registry-scope.ts). Profiles withleaseProvider: "proxy"get 5 minutes (PROXY_REMOTE_LEASE_TTL_MS), which hides the problem for uploads up to about 5 minutes (about 1.2 GB at 4 MB/s) but does not remove it. - #2517 keeps the lease alive for admitted work, but the install is admitted only after the upload finishes, when the lease may already have expired.
- A client retry cannot recover: the upload preflight never reports a cache hit (
src/daemon/resumable-upload.ts), so a retry uploads again under a new lease and fails the same way.
Expected
An install whose upload takes longer than the lease TTL still succeeds. Possible fixes:
- heartbeat the lease while the upload is in progress,
- have the daemon treat an in-progress upload for a lease as activity on that lease, or
- allocate or renew the lease after the upload finishes and before the install RPC.
Repro
A remote daemon with default lease settings and a profile without leaseProvider; agent-device install of an artifact that takes more than 60 s to upload (for example a 400+ MB debug APK on a ~4 MB/s uplink). With a proxy profile, an upload longer than 5 minutes.
Downstream: appandflow/stim#924. Stim is moving its generated remote profile to the proxy lease policy in appandflow/stim#1029 as a workaround.
- Dominant language
- TypeScript
- Stars
- 4.7k
- Forks
- 304
- Avg merge
- 11h 29m
- Merged PRs (30d)
- 514
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from callstack/agent-device
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
callstack/agent-device#1869 ·
-
needs-triage
Difficulty 5/5 Over a week Newbie friendliness 32/100
callstack/agent-device#2948 ·
-
needs-triage
Difficulty 4/5 3-5 days Newbie friendliness 45/100
callstack/agent-device#2940 ·
-
bug ready-for-agent
Difficulty 5/5 Over a week Newbie friendliness 35/100
callstack/agent-device#2935 ·
-
needs-triage
Difficulty 5/5 Over a week Newbie friendliness 38/100
callstack/agent-device#2906 ·
All issues in callstack/agent-device
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
bcgov/bc-wallet-mobile#4761 · 1 comment ·
-
external-issue to-triage
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
area-deployment area-integrations triage:bot-seen
Difficulty 2/5 Half a day Newbie friendliness 86/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
refactor
Difficulty 2/5 1-3 hours Newbie friendliness 84/100