Remote install: lease is not renewed during artifact upload
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 55/100
- Tipo de issue
- Error
- Claridad
- Bastante claro
- Estado de actividad
- Activo
- Stack tecnológico
- android, ios, typescript
- Área
- backend-api-design, cli, mobile-dev
Línea de trabajo
Start in src/cli/commands/connection-runtime.ts at allocateOrReuseLease, then trace prepareRemoteRequestArtifacts and uploadArtifact through src/daemon/upload*.ts and src/daemon/resumable-upload*.ts. Compare the lease lifecycle with src/daemon/lease-registry-scope.ts and src/daemon/resumable-upload.ts; done means an upload exceeding the lease TTL can still reach a successful install RPC.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Observed
agent-device install <449 MB .apk> --remote-config <profile> against a remote daemon (EAS Simulator Android session), with a profile that sets no leaseProvider, fails with UNAUTHORIZED: Lease is not active. Diagnostics show: lease_allocate with the default 60 s TTL, then a 1m47s artifact upload with no lease heartbeat, then the install RPC against the expired lease. A 30 MB iOS .app on the same path never hits it.
Cause (as read at efce352)
- The CLI heartbeats or allocates the lease once when the command starts (
src/cli/commands/connection-runtime.ts,allocateOrReuseLease). Nothing in the upload path (prepareRemoteRequestArtifacts/uploadArtifact,src/daemon/upload*.ts,src/daemon/resumable-upload*.ts) touches the lease. - The default connection policy sends no
ttlMs, so the daemon appliesDEFAULT_LEASE_TTL_MS = 60_000(src/daemon/lease-registry-scope.ts). Profiles withleaseProvider: "proxy"get 5 minutes (PROXY_REMOTE_LEASE_TTL_MS), which hides the problem for uploads up to about 5 minutes (about 1.2 GB at 4 MB/s) but does not remove it. - #2517 keeps the lease alive for admitted work, but the install is admitted only after the upload finishes, when the lease may already have expired.
- A client retry cannot recover: the upload preflight never reports a cache hit (
src/daemon/resumable-upload.ts), so a retry uploads again under a new lease and fails the same way.
Expected
An install whose upload takes longer than the lease TTL still succeeds. Possible fixes:
- heartbeat the lease while the upload is in progress,
- have the daemon treat an in-progress upload for a lease as activity on that lease, or
- allocate or renew the lease after the upload finishes and before the install RPC.
Repro
A remote daemon with default lease settings and a profile without leaseProvider; agent-device install of an artifact that takes more than 60 s to upload (for example a 400+ MB debug APK on a ~4 MB/s uplink). With a proxy profile, an upload longer than 5 minutes.
Downstream: appandflow/stim#924. Stim is moving its generated remote profile to the proxy lease policy in appandflow/stim#1029 as a workaround.
- Lenguaje dominante
- TypeScript
- Estrellas
- 4.7k
- Forks
- 304
- Merge medio
- 11 h 29 min
- PR fusionados (30 d)
- 514
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de callstack/agent-device
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
callstack/agent-device#1869 ·
-
needs-triage
Dificultad 5/5 Más de una semana Aptitud para principiantes 32/100
callstack/agent-device#2948 ·
-
needs-triage
Dificultad 4/5 3-5 días Aptitud para principiantes 45/100
callstack/agent-device#2940 ·
-
bug ready-for-agent
Dificultad 5/5 Más de una semana Aptitud para principiantes 35/100
callstack/agent-device#2935 ·
-
needs-triage
Dificultad 5/5 Más de una semana Aptitud para principiantes 38/100
callstack/agent-device#2906 ·
Todos los issues de callstack/agent-device
Issues similares
-
bug(cli): hapi doctor inline-media prints a fabricated B:\ helper-script path in packaged installs Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
-
Crush Abierto
Dificultad 1/5 Menos de una hora Aptitud para principiantes 85/100
catppuccin/catppuccin#3125 ·
-
Add a SECURITY.md Abierto
Dificultad 1/5 Menos de una hora Aptitud para principiantes 90/100
ElementsProject/cln-application#167 · 1 comentario · 1 reacción ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
Quantco/pnpm-licenses#17 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100