Carry the gesture no-effect fact on the snapshot tree like unsettledGesture
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 55/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- typescript
Research direction
The issue references specific files: src/daemon/gesture-no-effect.ts and src/daemon/selector-capture-runtime.ts. Start by understanding how SnapshotState.unsettledGesture works from #2839. Then, trace where gestureNoEffect is currently annotated and how to move it to the snapshot tree stamp. The goal is to delete withGestureNoEffectWarning and ensure selector reads (is, get, find) show the warning. Run existing tests related to gesture warnings to verify the change.
Written by the indexing model from the issue text.
Description
Problem
A proven no-effect gesture (gestureNoEffect, #1600) reaches the agent only through capture annotations (withGestureNoEffectWarning in src/daemon/gesture-no-effect.ts). src/daemon/selector-capture-runtime.ts keeps only the SnapshotState and drops those annotations. So is, get, and find never show the no-effect warning; only snapshot does.
#2839 made SnapshotState.unsettledGesture the single carrier for the unsettled post-gesture fact. Every route derives its disclosure from that stamp: selector reads through withCaptureDisclosures, and snapshot through buildSnapshotWarnings.
Proposal
Move gestureNoEffect to the same stamp on the tree and derive its disclosure the same way. This deletes withGestureNoEffectWarning and the annotation channel for it, and gives selector reads the warning they miss today.
Follow-up to #2839.
- Dominant language
- TypeScript
- Stars
- 4.7k
- Forks
- 304
- Avg merge
- 11h 29m
- Merged PRs (30d)
- 514
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from callstack/agent-device
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
callstack/agent-device#2842 ·
-
docs(ios-runner): RUNNER_PROTOCOL.md points at the wrong file and omits recovery and busy codes Opendocumentation good first issue ready-for-agent
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
callstack/agent-device#2797 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
callstack/agent-device#1869 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 65/100
callstack/agent-device#2853 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
callstack/agent-device#2833 ·
All issues in callstack/agent-device
Similar issues
-
bug(cli): hapi doctor inline-media prints a fabricated B:\ helper-script path in packaged installs Open
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Crush Open
Difficulty 1/5 Under an hour Newbie friendliness 85/100
catppuccin/catppuccin#3125 ·
-
Add a SECURITY.md Open
Difficulty 1/5 Under an hour Newbie friendliness 90/100
ElementsProject/cln-application#167 · 1 comment · 1 reaction ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Quantco/pnpm-licenses#17 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100