startProfiling and stopProfiling should agree on the default name

Open
#55 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
devtools

Research direction

Read lib/v8-profiler.js at startProfiling and stopProfiling, comparing their default-name handling. Determine the intended shared default behavior, make the two functions consistent, and verify that profiling can be started and stopped with the default name.

Written by the indexing model from the issue text.

Description

In v8-profiler.js it seems like startProfiling sets the default name to be

name = 'org.nodejs.profiles.cpu.user-initiated.' + (cpuCache.length + 1);

Meanwhile, stopProfiling sets the default name to be ''.

It seems like those should be consistent. I'm still wrapping my head around how everything fits together though, so please correct me if I'm confused.

Dominant language
JavaScript
Stars
1.1k
Forks
77
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from c4milo/node-webkit-agent

All issues in c4milo/node-webkit-agent

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.