Installation fails with node v0.12.0

Open
#78 12 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp, node.js

Research direction

Start with src/cpu_profiler.h and src/cpu_profiler.cc, then inspect src/profile.h and the node-gyp build configuration. Reproduce the failure with npm install under Node v0.12.0 and compare the native addon interfaces used there with the reported V8 errors. Done means the package installs successfully on that Node version.

Written by the indexing model from the issue text.

Description

npm install webkit-devtools-agent
/

ws@0.4.31 install /Users/mgawande/Desktop/src/scratch/node_modules/webkit-devtools-agent/node_modules/ws
(node-gyp rebuild 2> builderror.log) || (exit 0)

CXX(target) Release/obj.target/bufferutil/src/bufferutil.o

webkit-devtools-agent@0.3.1 install /Users/mgawande/Desktop/src/scratch/node_modules/webkit-devtools-agent
node-gyp rebuild

child_process: customFds option is deprecated, use stdio instead.
CXX(target) Release/obj.target/profiler/src/cpu_profiler.o
In file included from ../src/cpu_profiler.cc:1:
../src/cpu_profiler.h:19:57: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'?
static Handle GetProfilesCount(const Arguments& args);
^~~~~~~~~
v8::internal::Arguments
/Users/mgawande/.node-gyp/0.12.0/deps/v8/include/v8.h:127:7: note: 'v8::internal::Arguments' declared here
class Arguments;
^
In file included from ../src/cpu_profiler.cc:1:
../src/cpu_profiler.h:20:51: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'?
static Handle GetProfile(const Arguments& args);
^~~~~~~~~
v8::internal::Arguments
/Users/mgawande/.node-gyp/0.12.0/deps/v8/include/v8.h:127:7: note: 'v8::internal::Arguments' declared here
class Arguments;
^
In file included from ../src/cpu_profiler.cc:1:
../src/cpu_profiler.h:21:52: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'?
static Handle FindProfile(const Arguments& args);
^~~~~~~~~
v8::internal::Arguments
/Users/mgawande/.node-gyp/0.12.0/deps/v8/include/v8.h:127:7: note: 'v8::internal::Arguments' declared here
class Arguments;
^
In file included from ../src/cpu_profiler.cc:1:
../src/cpu_profiler.h:22:55: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'?
static Handle StartProfiling(const Arguments& args);
^~~~~~~~~
v8::internal::Arguments
/Users/mgawande/.node-gyp/0.12.0/deps/v8/include/v8.h:127:7: note: 'v8::internal::Arguments' declared here
class Arguments;
^
In file included from ../src/cpu_profiler.cc:1:
../src/cpu_profiler.h:23:54: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'?
static Handle StopProfiling(const Arguments& args);
^~~~~~~~~
v8::internal::Arguments
/Users/mgawande/.node-gyp/0.12.0/deps/v8/include/v8.h:127:7: note: 'v8::internal::Arguments' declared here
class Arguments;
^
In file included from ../src/cpu_profiler.cc:1:
../src/cpu_profiler.h:24:58: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'?
static Handle DeleteAllProfiles(const Arguments& args);
^~~~~~~~~
v8::internal::Arguments
/Users/mgawande/.node-gyp/0.12.0/deps/v8/include/v8.h:127:7: note: 'v8::internal::Arguments' declared here
class Arguments;
^
In file included from ../src/cpu_profiler.cc:2:
../src/profile.h:16:61: error: unknown type name 'AccessorInfo'
static Handle GetUid(Local property, const AccessorInfo& info);
^
../src/profile.h:17:63: error: unknown type name 'AccessorInfo'
static Handle GetTitle(Local property, const AccessorInfo& info);
^
../src/profile.h:18:65: error: unknown type name 'AccessorInfo'
static Handle GetTopRoot(Local property, const AccessorInfo& info);
^
../src/profile.h:19:68: error: unknown type name 'AccessorInfo'
static Handle GetBottomRoot(Local property, const AccessorInfo& info);
^
../src/profile.h:20:37: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'?
static Handle Delete(const Arguments& args);
^~~~~~~~~
v8::internal::Arguments
/Users/mgawande/.node-gyp/0.12.0/deps/v8/include/v8.h:127:7: note: 'v8::internal::Arguments' declared here
class Arguments;
^
../src/cpu_profiler.cc:8:21: error: calling a protected constructor of class 'v8::HandleScope'
HandleScope scope;
^
/Users/mgawande/.node-gyp/0.12.0/deps/v8/include/v8.h:816:13: note: declared protected here
V8_INLINE HandleScope() {}
^
../src/cpu_profiler.cc:10:62: error: 'New' is a private member of 'v8::PersistentBasev8::ObjectTemplate'
cpu_profiler_template_ = Persistent::New(ObjectTemplate::New());
^
/Users/mgawande/.node-gyp/0.12.0/deps/v8/include/v8.h:572:23: note: declared private here
V8_INLINE static T* New(Isolate* isolate, T* that);
^
../src/cpu_profiler.cc:10:34: error: too few arguments to function call, expected 2, have 1; did you mean 'Profile::New'?
cpu_profiler_template_ = Persistent::New(ObjectTemplate::New());
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Profile::New
../src/profile.h:13:24: note: 'Profile::New' declared here
static Handle New(const CpuProfile* profile);
^
../src/cpu_profiler.cc:11:31: error: member reference type 'Persistentv8::ObjectTemplate' is not a pointer; maybe you meant to use '.'?
cpu_profiler_template_->SetInternalFieldCount(1);
~~~~~~~~~~~~~~~~~~~~~~^~
.
../src/cpu_profiler.cc:11:33: error: no member named 'SetInternalFieldCount' in 'v8::Persistent<v8::ObjectTemplate,
v8::NonCopyablePersistentTraitsv8::ObjectTemplate >'
cpu_profiler_template_->SetInternalFieldCount(1);
~~~~~~~~~~~~~~~~~~~~~~ ^
../src/cpu_profiler.cc:13:62: error: member reference type 'Persistentv8::ObjectTemplate' is not a pointer; maybe you meant to use '.'?
Local cpuProfilerObj = cpu_profiler_template_->NewInstance();
~~~~~~~~~~~~~~~~~~~~~~^~
.
../src/cpu_profiler.cc:13:64: error: no member named 'NewInstance' in 'v8::Persistent<v8::ObjectTemplate,
v8::NonCopyablePersistentTraitsv8::ObjectTemplate >'
Local cpuProfilerObj = cpu_profiler_template_->NewInstance();
~~~~~~~~~~~~~~~~~~~~~~ ^
../src/cpu_profiler.cc:15:9: error: no matching function for call to 'NODE_SET_METHOD'
NODE_SET_METHOD(cpuProfilerObj, "getProfilesCount", CpuProfiler::GetProfilesCount);
^~~~~~~~~~~~~~~
/Users/mgawande/.node-gyp/0.12.0/src/node.h:240:25: note: expanded from macro 'NODE_SET_METHOD'

define NODE_SET_METHOD node::NODE_SET_METHOD

                    ^~~~~~~~~~~~~~~~~~~~~

/Users/mgawande/.node-gyp/0.12.0/src/node.h:228:13: note: candidate function [with TypeName = v8::Localv8::Object] not viable: no known conversion
from 'Handlev8::Value (const v8::internal::Arguments &)' to 'v8::FunctionCallback' (aka 'void ()(const FunctionCallbackInfov8::Value &)')
for 3rd argument
inline void NODE_SET_METHOD(const TypeName& recv,
^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make: *
* [Release/obj.target/profiler/src/cpu_profiler.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:267:23)
gyp ERR! stack at ChildProcess.emit (events.js:110:17)
gyp ERR! stack at Process.ChildProcess._handle.onexit (child_process.js:1067:12)
gyp ERR! System Darwin 13.4.0
gyp ERR! command "node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/mgawande/Desktop/src/scratch/node_modules/webkit-devtools-agent
gyp ERR! node -v v0.12.0
gyp ERR! node-gyp -v v1.0.2
gyp ERR! not ok
npm ERR! Darwin 13.4.0
npm ERR! argv "node" "/usr/local/bin/npm" "install" "webkit-devtools-agent"
npm ERR! node v0.12.0
npm ERR! npm v2.5.1
npm ERR! code ELIFECYCLE

npm ERR! webkit-devtools-agent@0.3.1 install: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the webkit-devtools-agent@0.3.1 install script 'node-gyp rebuild'.
npm ERR! This is most likely a problem with the webkit-devtools-agent package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! node-gyp rebuild
npm ERR! You can get their info via:
npm ERR! npm owner ls webkit-devtools-agent
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR! /Users/mgawande/Desktop/src/scratch/npm-debug.log

Dominant language
JavaScript
Stars
1.1k
Forks
77
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from c4milo/node-webkit-agent

All issues in c4milo/node-webkit-agent

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.