Question about the test output

Open
#4 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
cpp
Domain
testing-qa

Research direction

Start by running the unit test in evalImuFactor.cpp and compare its output with the reported evalAHRSFactor failures. Read the assertion assert_equal(scenario.rotation(scenario.duration()), runner.predict(pim), 1e-9) to determine what states are compared, then document whether the test output and comparison scope are expected.

Written by the indexing model from the issue text.

Description

Hi authors,

First, thank you for releasing the IMU-factor evaluation code.

I tried running the unit test in evalImuFactor.cpp and obtained the following console output:

./evalAHRSFactor 
Not equal:
expected:
 [
	-0.346692, 0.044757, -0.936911;
	-0.0291355, 0.997865, 0.0584501;
	0.937527, 0.0475615, -0.344648
]
actual:
 [
	0.925444, 0.308216, 0.220352;
	0.119303, -0.789052, 0.60263;
	0.359609, -0.531411, -0.766995
]
Failure: "assert_equal(scenario.rotation(scenario.duration()), runner.predict(pim), 1e-9)" 
Not equal:
expected:
 [
	0.0448764, 0.970451, 0.237093;
	0.359178, -0.237137, 0.902641;
	0.932191, 0.0446501, -0.359207
]
actual:
 [
	0.155674, -0.178706, -0.971508;
	-0.351104, 0.909267, -0.223518;
	0.923304, 0.375896, 0.0788047
]
Failure: "assert_equal(scenario.rotation(scenario.duration()), runner.predict(pim), 1e-9)" 
There were 2 failures
  1. Is this the same output you see on your side?
  2. Does the test compare the whole pre-integrated IMU trajectory against whole ground truth?
    From my understanding, it integrates IMU, then compares the predicted end NavState against the scenario’s ground-truth state at the same time.

Thanks

Dominant language
Jupyter Notebook
Stars
27
Forks
1
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from borglab/imuFactors

All issues in borglab/imuFactors

Similar issues

More Testing & QA issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.