Temp variable uses wrong storage
Maintainers usually reply within 1 day
@grisumbras is already working on this.
Since Apr 15, 2022.
Assessment
This issue has not been assessed yet.
Description
I think instead of using the array's storage it should use the default storage:
https://github.com/boostorg/json/blob/83c364afaf31b58cfe8b97ab159c406c508f47c9/include/boost/json/impl/array.hpp#L527
Otherwise we are allocating and deallocating in the wrong order, and we are not making correct use of monotonic storage. We should review all functions which require temporary storage (e.g. object::insert).
- Dominant language
- C++
- Stars
- 479
- Forks
- 110
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 3
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from boostorg/json
-
Difficulty 3/5 1-2 days Newbie friendliness 72/100
boostorg/json#1196 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
boostorg/json#1162 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
boostorg/json#1155 · 1 comment ·
Maintainers usually reply within 1 day
-
sanitizer warningOpen
Difficulty 3/5 1-2 days Newbie friendliness 45/100
boostorg/json#1133 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
MerginMaps/mobile#4741 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Icinga/icinga2#11077 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
-
agent:WSL bug linux LOW ui
Difficulty 1/5 Under an hour Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Copter: PosHold brake-entry threshold became 16 deg instead of 0.16 deg after the radians conversionPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 1/5 Under an hour Newbie friendliness 78/100
ArduPilot/ardupilot#34617 · 1 comment · 1 reaction ·
Maintainers usually reply within 1 day