CI for MSVC 14.4 silently breaks

Closed
  • Is something wrong?
#1,497 0 comments 1 reaction 0 assignees View on GitHub

Maintainers usually reply within 4 days

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
1-2 days
Newbie friendliness
52/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
cpp, github-actions
Domain
build-system, ci-cd

Research direction

Start by inspecting the linked CI run and the workflow that introduced the MSVC job; the issue does not name the workflow file or tests. Check how the job selects the MSVC toolset and how configuration or build failures affect its exit status. Done when the intended MSVC target is built and a failed or incorrect configuration makes the CI job fail.

Written by the indexing model from the issue text.

Description

Note https://github.com/boostorg/geometry/actions/runs/38219123105/job/114710822959#step:7:35

warning: Did not find command for MSVC toolset. If you have Visual Studio 2017 installed you will need to specify the full path to the command, set VS150COMNTOOLS for your installation, or build from the 'Visual Studio Command Prompt for VS 2017'.

Performing configuration checks

- default address-model    : none [1]
- symlinks supported       : yes (cached)
- cxx14_constexpr          : no [2]
- cxx14_constexpr          : no [3]
- cxx14_constexpr          : no [4]
- cxx14_constexpr          : no [5]
- cxx14_constexpr          : no [6]
- cxx14_constexpr          : no [7]
- cxx14_constexpr          : no [8]
- cxx14_constexpr          : no [9]

[1] msvc-14.4
[2] msvc-14.4/debug/address-model-32/cxxstd-14-iso/threading-multi/visibility-hidden
[3] msvc-14.4/debug/address-model-32/build-no/cxxstd-14-iso/threadapi-win32/threading-multi/visibility-hidden
[4] msvc-14.4/debug/address-model-64/cxxstd-14-iso/threading-multi/visibility-hidden
[5] msvc-14.4/debug/address-model-64/build-no/cxxstd-14-iso/threadapi-win32/threading-multi/visibility-hidden
[6] msvc-14.4/release/address-model-32/cxxstd-14-iso/threading-multi/visibility-hidden
[7] msvc-14.4/release/address-model-32/build-no/cxxstd-14-iso/threadapi-win32/threading-multi/visibility-hidden
[8] msvc-14.4/release/address-model-64/cxxstd-14-iso/threading-multi/visibility-hidden
[9] msvc-14.4/release/address-model-64/build-no/cxxstd-14-iso/threadapi-win32/threading-multi/visibility-hidden
...found 1 target...

So there are two bugs here: 1) Not finding the right toolchain (assuming that Visual Studio 2017 with VS150COMNTOOLS is the intended toolchain for msvc-14.4 in VS' famous versioning scheme) and more importantly 2) not giving a return code that gets highlighted as failure even though it's not building the intended target. I'll try to look into it next week.

While the relevant logs are long expired, judging from the runtime discrepancy, this goes back to the introduction of this CI job https://github.com/boostorg/geometry/actions/runs/20078053940 .

Dominant language
C++
Stars
517
Forks
237
Avg merge
5d 18h
Merged PRs (30d)
4

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from boostorg/geometry

All issues in boostorg/geometry

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.