regression: retargeting to trunk never prompts to take the PR out of draft
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 55/100
Research direction
Start in the sync flow that retargets child pull requests when a stack branch is merged into trunk, and review the regression context in #100. Verify that a newly trunk-targeted draft PR prompts once to become ready for review, while subsequent syncs and already-ready PRs do not prompt again.
Written by the indexing model from the issue text.
Description
When we sync, a branch in a stack has been merged into the trunk, the "children" of this branch will be retargeted to trunk. The PRs associated with these children will (unless there's been manual intervention) be in "draft" status; since they now target the trunk, they should be "ready for review."
I no longer see a prompt to mark such PRs as "ready for review." Mind you, we should only ever ask to do this once (no asking again on a subsequent sync), and only if the PR is currently in "draft" status.
This regression may have been introduced by #100.
- Dominant language
- Go
- Stars
- 9
- Forks
- 2
- Avg merge
- 15h 9m
- Merged PRs (30d)
- 4
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from boneskull/gh-stack
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 25/100
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 48/100
-
performance
Difficulty 5/5 Over a week Newbie friendliness 35/100
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 35/100
All issues in boneskull/gh-stack
Similar issues
-
agent-research-recommend agent-review-finding chore
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
jordansmall/spindrift#4821 · 1 comment ·
Maintainers usually reply within 1 day
-
area:web
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
praetorianer777/GoTome#178 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
oracle/go-oracledb#105 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day