submit: use terminal links

Open Beginner friendly
#139 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
82/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
github, go
Domain
cli

Research direction

Read internal/style/style.go at the Hyperlink function and compare it with the existing update notice in cmd/submit.go. Trace the new-PR output in gh stack submit, then ensure its PR URL uses the same terminal-link behavior and verify the resulting output.

Written by the indexing model from the issue text.

Description

enhancement

The output when gh stack submit creates a new PR looks like this:

=== Phase 3: PRs ===
✓ Created PR #1234 for boneskull/derp (https://github.com/boneskull/derp/pull/1234)

This should instead use the Hyperlink function:

https://github.com/boneskull/gh-stack/blob/f157268d3a8732ad3f14be55e4d0408bc65a1004/internal/style/style.go#L208-L217

gh stack submit uses this function when emitting a notice about updating a PR; see:

https://github.com/boneskull/gh-stack/blob/f157268d3a8732ad3f14be55e4d0408bc65a1004/cmd/submit.go#L474

Dominant language
Go
Stars
9
Forks
2
Avg merge
9h 14m
Merged PRs (30d)
8

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from boneskull/gh-stack

All issues in boneskull/gh-stack

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.