dashboard: holding Enter on the focused Stop button sends an interrupt per key repeat
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 60/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- react, typescript
- Domain
- frontend
Research direction
The Stop button is in packages/dashboard/src/components/InputBar.tsx, the button with data-testid="interrupt-button" whose onClick calls onInterrupt. First reproduce in a browser: focus that button and hold Enter, then count the interrupt frames sent. If repeats do send several, add a test that fails on current main and fix it so one physical press sends one frame, while mouse click and single Enter or Space still work. If they do not, close the issue with that measurement.
Written by the indexing model from the issue text.
Description
Context
Filed from: #9269 (https://github.com/blamechris/chroxy/pull/9269#issuecomment-7071222287)
Identified during review of PR #9269.
Location: packages/dashboard/src/components/InputBar.tsx (the Stop button, data-testid="interrupt-button", onClick={onInterrupt})
Description
#9269 made a held Escape or Cmd+. act once. The Stop button is a third way to reach the same door. A browser fires click on a focused <button> for every Enter keydown, including auto-repeats, so holding Enter while the Stop button has focus calls onInterrupt once per repeat. After output has started that is one interrupt frame per repeat. Before the first output it re-parks the same confirmation, which is harmless.
The button only has focus after a click or a Tab to it, and it unmounts once the session goes idle, so this is rare. #9269 listed it as not examined. It has not been reproduced in a browser.
Acceptance Criteria
- Confirm in a real browser whether holding Enter on the focused Stop button sends more than one
interruptframe. - If it does: one physical press sends one frame, with a test that is red on current main. A mouse click and a single Enter or Space press keep working.
- If it does not: close with the measurement.
- Dominant language
- JavaScript
- Stars
- 7
- Forks
- 1
- Avg merge
- 2h 19m
- Merged PRs (30d)
- 263
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from blamechris/chroxy
-
priority: low server testing
Difficulty 1/5 Under an hour Newbie friendliness 88/100
blamechris/chroxy#9277 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
blamechris/chroxy#9272 ·
Maintainers usually reply within 1 day
-
bug server
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
blamechris/chroxy#9248 ·
Maintainers usually reply within 1 day
-
documentation from-review
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
blamechris/chroxy#9237 ·
Maintainers usually reply within 1 day
-
enhancement from-review
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
blamechris/chroxy#9232 ·
Maintainers usually reply within 1 day
All issues in blamechris/chroxy
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
cytoscape/cytoscape.js#3597 ·
Maintainers usually reply within 5 days
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
sunososobro-hub/cloudball#191 ·
Maintainers usually reply within 1 day
-
[MCP]: page snapshots in .playwright-mcp/ are not git-ignored (.playwright-cli/ is, since #42318)Open
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
microsoft/playwright#44289 ·
Maintainers usually reply within 1 day
-
Wire ISO post: has() accepts text values such as an empty string, true or 0x1A for wire numbersOpenarea:post effort:low enhancement P7 source:agent
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
marketing
Difficulty 2/5 Half a day Newbie friendliness 78/100
Maintainers usually reply within 1 day