Report blocked requests even when a modal layout case fails earlier
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
- Issue type
- Refactor
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- javascript, node.js
- Domain
- testing
Research direction
Open packages/dashboard/scripts/modal-buttons-layout.test.mjs and find where assert.deepEqual(blocked, [], …) runs after measure() and the case's own assertions. Read the surrounding helper that collects blocked requests and WebSocket attempts, then move the reporting into a finally (or catch-and-rethrow) so it runs on any failure path. Run the file with node --test packages/dashboard/scripts/modal-buttons-layout.test.mjs; done looks like a deliberately blocked URL named in the failure output while pass/fail results stay unchanged.
Written by the indexing model from the issue text.
Description
Context
Filed from: #9231
Identified during the review of PR #9231 (#8779).
Description
In packages/dashboard/scripts/modal-buttons-layout.test.mjs, the check that no request left the fixture server and no WebSocket was attempted (assert.deepEqual(blocked, [], …)) runs only after measure() and the case's own assertions succeed. If a blocked request causes a timeout or an earlier assertion to fail, the case still fails, but its error does not name the blocked URL, which makes the cause harder to see. Behaviour stays fail-closed: a blocked attempt can never let a case pass.
Related nitpicks from the same review, optional:
context.route('**/*')could use an explicit match-all (/.*/or a predicate) instead of relying on glob conversion.- In the static server,
ENOTDIR/ELOOPfromrealpathSyncreturn 500 rather than 404 (no safety impact).
Original Review Comment
The blocked-request assertion only runs after
measure()andfn()succeed. If a blocked request causes a timeout or an assertion failure, the case reports that failure without naming the blocked URL.
Acceptance Criteria
- A case that fails for any reason also reports any blocked request or WebSocket attempt in its failure output
- Pass/fail behaviour is unchanged (any blocked attempt still fails the case)
- Dominant language
- JavaScript
- Stars
- 7
- Forks
- 1
- Avg merge
- 2h 19m
- Merged PRs (30d)
- 263
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from blamechris/chroxy
-
priority: low server testing
Difficulty 1/5 Under an hour Newbie friendliness 88/100
blamechris/chroxy#9277 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
blamechris/chroxy#9272 ·
Maintainers usually reply within 1 day
-
complexity: low dashboard enhancement from-review
Difficulty 2/5 1-3 hours Newbie friendliness 60/100
blamechris/chroxy#9271 ·
Maintainers usually reply within 1 day
-
bug server
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
blamechris/chroxy#9248 ·
Maintainers usually reply within 1 day
-
documentation from-review
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
blamechris/chroxy#9237 ·
Maintainers usually reply within 1 day
All issues in blamechris/chroxy
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
cytoscape/cytoscape.js#3597 ·
Maintainers usually reply within 5 days
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
sunososobro-hub/cloudball#191 ·
Maintainers usually reply within 1 day
-
[MCP]: page snapshots in .playwright-mcp/ are not git-ignored (.playwright-cli/ is, since #42318)Open
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
microsoft/playwright#44289 ·
Maintainers usually reply within 1 day
-
Wire ISO post: has() accepts text values such as an empty string, true or 0x1A for wire numbersOpenarea:post effort:low enhancement P7 source:agent
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
marketing
Difficulty 2/5 Half a day Newbie friendliness 78/100
Maintainers usually reply within 1 day