Java: close the internally created HttpClient in Bitpin.close()
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 70/100
Research direction
Start by reading Config to see how it distinguishes an internally created java.net.http.HttpClient from one supplied by the user, then trace how Bitpin.close() disconnects the WebSocket. Update the close lifecycle so it closes only the internally created client. Done means closing an SDK client releases its internally created HttpClient while leaving a user supplied client open.
Written by the indexing model from the issue text.
Description
When no httpClient/restTransport is configured, Config builds a java.net.http.HttpClient. Since Java 21, HttpClient is AutoCloseable, and each one keeps a selector thread until it is garbage-collected. Bitpin.close() only disconnects the WebSocket.
For apps that create many short-lived clients, close() should also close the HttpClient the SDK created itself, but never one the user passed in.
- Dominant language
- Python
- Stars
- 0
- Forks
- 0
- Avg merge
- 28m
- Merged PRs (30d)
- 20
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from bitpin-dev/bitpin-sdk
-
documentation java release
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
bitpin-dev/bitpin-sdk#32 ·
Maintainers usually reply within 1 day
-
docs help wanted i18n
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
bitpin-dev/bitpin-sdk#8 ·
Maintainers usually reply within 1 day
-
enhancement go java websocket
Difficulty 4/5 3-5 days Newbie friendliness 52/100
bitpin-dev/bitpin-sdk#33 ·
Maintainers usually reply within 1 day
-
bug python security
Difficulty 4/5 3-5 days Newbie friendliness 55/100
bitpin-dev/bitpin-sdk#30 ·
Maintainers usually reply within 1 day
-
release typescript
Difficulty 4/5 1-2 days Newbie friendliness 15/100
bitpin-dev/bitpin-sdk#12 ·
Maintainers usually reply within 1 day
All issues in bitpin-dev/bitpin-sdk
Similar issues
-
Support .aac audio uploadsPossibly taken @julien731 claimed this today. Openfeature
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
nimblehq/audio-transcriber#153 ·
-
help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
antonyrag/ragleap-core#1062 ·
-
needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
gke-labs/kube-agents#4321 ·
Maintainers usually reply within 1 day
-
enhancement help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Git-Hospital/githealthcheck#61 ·
Maintainers usually reply within 1 day
-
changelog investigate
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
ramnes/notion-sdk-py#433 ·