Sanitizing input text for "get" queries?
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
Research direction
Reproduce the failure with the /study/1/samples endpoint and the term value shown in the issue. Trace the server-side handler for that GET query and determine how the quoted input reaches the failing operation; done means the request no longer returns a 500 for this specimen ID and the expected query behavior is covered by a regression test.
Written by the indexing model from the issue text.
Description
Doesn't look like this has been logged as an issue before, so I'm documenting it here.
In the style of xkcd, I tried plating a specimen with the ID ');console.log('hi');. Fortunately, this doesn't result in hi being printed to the console; unfortunately, it does cause a 500 internal server error:
GET https://127.0.0.1:8181/study/1/samples?term=%27);console.log(%27hi%27); 500 (Internal Server Error)
Looks like it's the ' character (which gets converted to %27) that's problematic.
I don't imagine this is a common use case, but it might be worth addressing?
Edit: also, if this behavior is expected (i.e. the server throws an error if it detects a wacky specimen ID like ');console.log('hi');) then sorry, and feel free to close this.
- Dominant language
- Python
- Stars
- 2
- Forks
- 15
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from biocore/LabControl
-
bug front-end question
Difficulty 4/5 3-5 days Newbie friendliness 30/100
biocore/LabControl#594 ·
-
front-end question
Difficulty 5/5 Over a week Newbie friendliness 35/100
biocore/LabControl#593 ·
-
front-end
biocore/LabControl#592 · 1 assignee ·
-
code refactor front-end
Difficulty 5/5 Over a week Newbie friendliness 25/100
biocore/LabControl#591 ·
-
priority:low
Difficulty 3/5 1-2 days Newbie friendliness 20/100
biocore/LabControl#590 ·
All issues in biocore/LabControl
Similar issues
-
agent-ready documentation needs-triage
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
-
documentation
Difficulty 1/5 Under an hour Newbie friendliness 91/100
-
workflow-status page template still says reusable workflows are "triggered only by workflow_call:" Open
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
instance instance add
Difficulty 1/5 Under an hour Newbie friendliness 72/100
searxng/searx-instances#939 · 1 comment ·
-
area-deployment area-integrations triage:bot-seen
Difficulty 2/5 Half a day Newbie friendliness 86/100