Check to ensure samples that get a SequencingProcess._generate_sample_proj_value of None are NOT experimental?

Open
#511 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
python
Domain
backend

Research direction

Start with labcontrol/db/process.py around _generate_sample_proj_value and review the referenced TODO lines 3215-3221. Investigate how samples without Qiita data are classified and determine the expected behavior for experimental samples. Done means the intended rule is confirmed and covered by an appropriate test, if the project has one.

Written by the indexing model from the issue text.

Description

Before a recent refactor, SequencingProcess._generate_sample_proj_value included the following TODO:

https://github.com/jdereus/labman/blob/f930206122f5adc0f12afb004021ce8fec77851e/labcontrol/db/process.py#L3215-L3221

Memorializing this here so it isn't forgotten. I vaguely recall we actually HAVE seen cases where the sample project was none for experimental samples, I think because they didn't have data in qiita.

Dominant language
Python
Stars
2
Forks
15
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from biocore/LabControl

All issues in biocore/LabControl

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.