Enh: domain/ layer imports isar_community directly in 3 files — violates Clean Architecture rule
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 48/100
Research direction
Start by reading the three named service/use-case files and the existing GanaRepository/GanaRepositoryImpl pattern. Run grep -rn "package:isar_community" lib/domain/ to confirm the violations. Done means Isar access in each file goes through a Domain repository interface implemented in lib/data/, and the grep finds no remaining Domain imports.
Written by the indexing model from the issue text.
Description
"Domain layer... Has zero imports from isar_community, flutter, or any presentation package." Three existing files break this — the Domain layer
should only reach Isar through repository interfaces implemented in lib/data/, but these reach into Isar directly:
- lib/domain/services/nip17_encryption_service.dart:4
- lib/domain/services/marmot_transport_service.dart:3
- lib/domain/usecases/dm_usecases.dart:3
Verify with:
grep -rn "package:isar_community" lib/domain/
This predates the recent Gana cloud-support work (that work was checked against this exact rule and introduced no new violations — see docs/AUDIT.md, 2026-08-11
entry). Not urgent, not touched mid-feature — flagging for a deliberate cleanup pass: each of these three needs its Isar access moved behind a repository interface
(Domain) + implementation (Data), following the pattern already used everywhere else in the codebase (e.g. GanaRepository/GanaRepositoryImpl).
- Dominant language
- Dart
- Stars
- 2
- Forks
- 2
- Avg merge
- 19h 21m
- Merged PRs (30d)
- 37
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from basictech01/uniun
-
bug good first issue P2-Medium
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
basictech01/uniun#305 ·
Maintainers usually reply within 1 day
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
basictech01/uniun#300 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 4/5 1-2 days Newbie friendliness 42/100
basictech01/uniun#306 · 1 comment ·
Maintainers usually reply within 1 day
-
bug good first issue P2-Medium
Difficulty 3/5 1-2 days Newbie friendliness 52/100
basictech01/uniun#304 ·
Maintainers usually reply within 1 day
-
bug good first issue
Difficulty 3/5 1-2 days Newbie friendliness 52/100
basictech01/uniun#301 ·
Maintainers usually reply within 1 day
All issues in basictech01/uniun
Similar issues
-
good first issue spells
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 2 days
-
Standalone dash flashes as its own RSVP step (e.g. Russian dialogue)Possibly taken @bezig01 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
daniel-pimenta-cc/ledor#53 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 2 days