Failed loading filenames with `+`
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- aws, javascript
Research direction
Start by reading index.js at lines 785-790 and reproduce the manifest generation with the S3 filename hello+world.csv. Confirm that the generated manifest preserves the plus sign and that Redshift can load the referenced key without a missing-key error.
Written by the indexing model from the issue text.
Description
https://github.com/awslabs/aws-lambda-redshift-loader/blob/master/index.js#L785-L790
This line is replacing all + with (whitespace) which is problematic for filenames with +, e.g.:
Original filename in S3: hello+world.csv
Generated manifest: hello world.csv
Then Redshift will complain the key does not exist when trying to load the manifest.
I manually changed it to:
url: 's3://' + batchEntries[i],
and it worked fine for me.
- Dominant language
- JavaScript
- Stars
- 595
- Forks
- 161
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from awslabs/aws-lambda-redshift-loader
-
Difficulty 1/5 Under an hour Newbie friendliness 68/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 32/100
awslabs/aws-lambda-redshift-loader#247 · 3 comments ·
-
Manifest missing file returned in describeBatch.jsMay be free again @IanMeyers claimed this 1390 days ago, and no pull request is open. Open
awslabs/aws-lambda-redshift-loader#244 · 4 comments · 1 assignee ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
awslabs/aws-lambda-redshift-loader#239 · 4 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 20/100
awslabs/aws-lambda-redshift-loader#238 · 1 comment ·
All issues in awslabs/aws-lambda-redshift-loader
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
microsoft/playwright#43327 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
microsoft/TypeScript#64758 ·
Maintainers usually reply within 1 day
-
needs-area-label
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 65/100
-
bug good first issue help wanted status: planned
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
andersthemagi/reliquary#310 ·
Maintainers usually reply within 1 day