Missing callback in createS3EventSource when notification configuration already exists

Open Beginner friendly
#211 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
68/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
aws, javascript
Domain
cloud

Research direction

Read common.js around line 574, focusing on createS3EventSource and the branch for an existing notification configuration. Confirm the callback is reached when the configuration already exists, while the existing creation path remains unchanged; verify the surrounding behavior with the repository's available checks.

Written by the indexing model from the issue text.

Description

common.js/createS3EventSource method:
There is a missing callback in case of notification configuration already exists.

At line 574 of common.js
Could you please change the code from:

if (!configAlreadyExists){
logger.info('Creating notification configuration');

to:

if (configAlreadyExists) {
callback();
} else {
logger.info('Creating notification configuration');

Dominant language
JavaScript
Stars
595
Forks
161
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from awslabs/aws-lambda-redshift-loader

All issues in awslabs/aws-lambda-redshift-loader

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.