concurrency/executor.py: branch-pool copy_context gate reaches private _plugins

Open Beginner friendly
#794 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
85/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Active
Tech stack
python
Domain
backend, devtools

Research direction

Read aws_durable_execution_sdk_python/concurrency/executor.py around line 296 and compare the existing has_plugins use in execution.py around line 572. Change the gate to use the exposed property, then run the relevant concurrency executor tests. Done when the gate no longer accesses _plugins directly and the tests pass.

Written by the indexing model from the issue text.

Description

enhancement

aws_durable_execution_sdk_python/concurrency/executor.py:296 reads the executor's instance list through a noqa: SLF001:

if execution_state._plugin_executor._plugins:  # noqa: SLF001

PluginExecutor already exposes has_plugins for the same purpose, and execution.py:572 uses that. Can this gate switch to self._plugin_executor.has_plugins? Then both gates agree on one check and the private-attribute access goes away.

Dominant language
Python
Stars
59
Forks
32
Avg merge
1d 5h
Merged PRs (30d)
76

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from aws/aws-durable-execution-sdk-python

All issues in aws/aws-durable-execution-sdk-python

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.