[HttpClient] Warmup measurements might be off
@CarnaViire is already working on this.
Since May 31, 2024.
Assessment
This issue has not been assessed yet.
Description
If ran locally and with some of the tracing on, the client fairly often reports this exception:
Unhandled exception: System.Exception: No successful requests during warmup.
at HttpClientBenchmarks.Program.Measure(Func`1 sendAsync) in /home/manicka/repositories/aspnet-benchmarks/src/BenchmarksApps/HttpClientBenchmarks/Clients/HttpClient/Program.cs:line 312
at HttpClientBenchmarks.Program.RunScenario() in /home/manicka/repositories/aspnet-benchmarks/src/BenchmarksApps/HttpClientBenchmarks/Clients/HttpClient/Program.cs:line 222
at HttpClientBenchmarks.Program.<>c.<<Main>b__14_0>d.MoveNext() in /home/manicka/repositories/aspnet-benchmarks/src/BenchmarksApps/HttpClientBenchmarks/Clients/HttpClient/Program.cs:line 58
--- End of stack trace from previous location ---
at System.CommandLine.Invocation.AnonymousCommandHandler.InvokeAsync(InvocationContext context)
at System.CommandLine.Invocation.InvocationPipeline.<>c__DisplayClass4_0.<<BuildInvocationChain>b__0>d.MoveNext()
--- End of stack trace from previous location ---
at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass22_0.<<UseParseErrorReporting>b__0>d.MoveNext()
--- End of stack trace from previous location ---
at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass15_0.<<UseHelp>b__0>d.MoveNext()
--- End of stack trace from previous location ---
at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass26_0.<<UseVersionOption>b__0>d.MoveNext()
--- End of stack trace from previous location ---
at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass24_0.<<UseTypoCorrections>b__0>d.MoveNext()
--- End of stack trace from previous location ---
at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c.<<UseSuggestDirective>b__23_0>d.MoveNext()
--- End of stack trace from previous location ---
at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass21_0.<<UseParseDirective>b__0>d.MoveNext()
--- End of stack trace from previous location ---
at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c.<<UseDebugDirective>b__8_0>d.MoveNext()
--- End of stack trace from previous location ---
at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c.<<RegisterWithDotnetSuggest>b__7_0>d.MoveNext()
--- End of stack trace from previous location ---
at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass11_0.<<UseExceptionHandler>b__0>d.MoveNext()
While I clearly see in the logs, that requests were exchange with the server.
Note that the client's Main was altered to start with:
public static async Task<int> Main(string[] args)
{
using var _ = new TestEventListener(Console.Out, "Private.InternalDiagnostics.System.Net.Quic", "Private.InternalDiagnostics.System.Net.Http");
...
/cc @CarnaViire
- Dominant language
- C#
- Stars
- 1.2k
- Forks
- 244
- Avg merge
- 4d 4h
- Merged PRs (30d)
- 7
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from aspnet/Benchmarks
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
aspnet/Benchmarks#2226 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
aspnet/Benchmarks#2015 · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 42/100
aspnet/Benchmarks#2204 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
aspnet/Benchmarks#2161 ·
-
Test io_uring impactOpen
Difficulty 4/5 3-5 days Newbie friendliness 20/100
aspnet/Benchmarks#2153 · 21 reactions ·
All issues in aspnet/Benchmarks
Similar issues
-
area-NavigationView bug needs-triage team-Controls
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
microsoft/microsoft-ui-xaml#12671 · 3 comments ·
Maintainers usually reply within 2 days
-
Retarget the extension to Fallout 10.5Possibly taken @ChrisonSimtian claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
Improve time codes: status hint doesn't mention the new Shift+F7 / Shift+F8 "to check" navigationOpen
Difficulty 1/5 Under an hour Newbie friendliness 88/100
SubtitleEdit/subtitleedit#16943 ·
Maintainers usually reply within 1 day