Consider unifying our benchmark implementation with the TechEmpower one

Open
#1,815 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp
Domain
performance

Research direction

Compare src/BenchmarksApps/TechEmpower/PlatformBenchmarks in aspnet/Benchmarks with frameworks/CSharp/aspnetcore/PlatformBenchmarks in TechEmpower/FrameworkBenchmarks. Review the implementation differences, especially Dapper, EF, and MySQL support, and determine how a shared source can preserve those options. Done means the implementations can be synchronized by copying the unified code wholesale without divergence.

Written by the indexing model from the issue text.

Description

We currently have two implementations of e.g. TE platforms: one here, and one in the TechEmpower repo. The code is mostly the same, but there are some differences; this leads to constant laborious synchronization of the two, to keep them from diverging etc.

Why not have just a single source base, which we can sync by just copying code wholesale from here to there?

Note that there are two main data-related differences:

  • We have Dapper and EF, the TechEmpower code doesn't.
  • The TechEmpower code has MySQL (behind #ifs), we don't.

We can unify to have everything, but not necessarily run e.g. Dapper/EF at TechEmpower.

/cc @sebastienros @DamianEdwards

Dominant language
C#
Stars
1.2k
Forks
244
Avg merge
4d 4h
Merged PRs (30d)
7

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from aspnet/Benchmarks

All issues in aspnet/Benchmarks

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.