Consider unifying our benchmark implementation with the TechEmpower one
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- csharp
- Domain
- performance
Research direction
Compare src/BenchmarksApps/TechEmpower/PlatformBenchmarks in aspnet/Benchmarks with frameworks/CSharp/aspnetcore/PlatformBenchmarks in TechEmpower/FrameworkBenchmarks. Review the implementation differences, especially Dapper, EF, and MySQL support, and determine how a shared source can preserve those options. Done means the implementations can be synchronized by copying the unified code wholesale without divergence.
Written by the indexing model from the issue text.
Description
We currently have two implementations of e.g. TE platforms: one here, and one in the TechEmpower repo. The code is mostly the same, but there are some differences; this leads to constant laborious synchronization of the two, to keep them from diverging etc.
Why not have just a single source base, which we can sync by just copying code wholesale from here to there?
Note that there are two main data-related differences:
- We have Dapper and EF, the TechEmpower code doesn't.
- The TechEmpower code has MySQL (behind #ifs), we don't.
We can unify to have everything, but not necessarily run e.g. Dapper/EF at TechEmpower.
/cc @sebastienros @DamianEdwards
- Dominant language
- C#
- Stars
- 1.2k
- Forks
- 244
- Avg merge
- 4d 4h
- Merged PRs (30d)
- 7
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from aspnet/Benchmarks
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
aspnet/Benchmarks#2226 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
aspnet/Benchmarks#2015 · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 42/100
aspnet/Benchmarks#2204 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
aspnet/Benchmarks#2161 ·
-
Test io_uring impactOpen
Difficulty 4/5 3-5 days Newbie friendliness 20/100
aspnet/Benchmarks#2153 · 21 reactions ·
All issues in aspnet/Benchmarks
Similar issues
-
area-NavigationView bug needs-triage team-Controls
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
microsoft/microsoft-ui-xaml#12671 · 3 comments ·
Maintainers usually reply within 2 days
-
Retarget the extension to Fallout 10.5Possibly taken @ChrisonSimtian claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
Improve time codes: status hint doesn't mention the new Shift+F7 / Shift+F8 "to check" navigationOpen
Difficulty 1/5 Under an hour Newbie friendliness 88/100
SubtitleEdit/subtitleedit#16943 ·
Maintainers usually reply within 1 day