Feature request: Print a red warning when Total Requests == Bad Responses

Open
#1,119 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
42/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp

Research direction

Start by locating BenchmarksDriver and the code that formats the benchmark summary. Reproduce a run where Total Requests equals Bad Responses, then verify that a red warning is printed for that condition without changing other metrics.

Written by the indexing model from the issue text.

Description

Today I was running a lot of benchmarks and when I got some really high RPS after looking at all the numbers I realized that this was because of the typo I made in --path.

It would be great if BenchmarksDriver could print some red warning when Total Requests == Bad Response

RequestsPerSecond:           778 976
Max CPU (%):                 99
WorkingSet (MB):             499
Avg. Latency (ms):           1,05
Startup (ms):                302
First Request (ms):          60,33
Latency (ms):                0,16
Total Requests:              3 972 791
Duration: (ms)               5 100
Socket Errors:               0
Bad Responses:               3 972 791
SDK:                         3.0.100-preview7-012414
Runtime:                     3.0.0-preview7-27815-05
Dominant language
C#
Stars
1.2k
Forks
244
Avg merge
4d 4h
Merged PRs (30d)
7

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from aspnet/Benchmarks

All issues in aspnet/Benchmarks

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.