lints workflow : feature or crate selection

Open
#7 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
github-actions, rust
Domain
build-system, ci-cd

Research direction

Start by reading .github/workflows/lints.yml in ci-workflows, the gbench/Cargo.toml feature definition, and the referenced PR #255. Compare how the doc step invokes the lint crate and determine which crate or feature-selection behavior should be supported. Done means the workflow can handle the documented crate and feature-selection cases without failing on unsupported default features.

Written by the indexing model from the issue text.

Description

Documenting an issue encountered in https://github.com/lurk-lab/neptune/pull/255, which is arguably the fault of the crate organization:

Three ways to solve this:

  • make the gbench feature non-default, just generate a runtime panic if neither of opencl nor cuda are active,
  • allow excluding a crate from the doc test,
  • allow excluding a feature (or running with default-deatures = false) from the doc test,
Dominant language
No language data
Stars
0
Forks
3
Avg merge
59m
Merged PRs (30d)
2

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from argumentcomputer/ci-workflows

All issues in argumentcomputer/ci-workflows

Similar issues

More Build System issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.