`bench-deploy`: Convert between Criterion JSON formats
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- github-actions
- Domain
- ci-cd
Research direction
Trace the existing gh-pages and commit-comment benchmark workflow paths and inspect the Criterion JSON formats they produce. Use jq to define the conversion between those formats, then verify that one benchmark per commit can support criterion-table, plots, and deployment without separate reruns.
Written by the indexing model from the issue text.
Description
After #44
Currently, our gh-pages benchmark JSONs can't be used with criterion-table and our commit-comment benchmarks can't be used in plots. After some testing I've found that reformatting the JSON files is fairly straightforward using jq. This would have several benefits:
- Run only one benchmark per commit, rather than fiddling with env vars to produce several for use in our various comparison tools. This saves time and UX hassle
- Cached
commit-commentbenchmarks could be immediately deployed when a PR is merged, rather than having to re-run the benchmark in thegh-pagesformat for plotting & deployment. This saves time, runner resources and clutter ingh-pages
- Dominant language
- No language data
- Stars
- 0
- Forks
- 3
- Avg merge
- 59m
- Merged PRs (30d)
- 2
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from argumentcomputer/ci-workflows
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
-
Difficulty 3/5 1-2 days Newbie friendliness 25/100
-
Difficulty 3/5 1-2 days Newbie friendliness 42/100
-
Difficulty 4/5 3-5 days Newbie friendliness 30/100
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
All issues in argumentcomputer/ci-workflows
Similar issues
-
kind/bug needs-triage
Difficulty 1/5 Under an hour Newbie friendliness 72/100
matrixorigin/matrixone#29223 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
copse-dev/agent-pane#2953 ·
-
bug ci-failure high priority
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
vllm-project/vllm-omni#7972 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
simonw/sqlite-utils#872 ·
-
bug good first issue
Difficulty 1/5 Under an hour Newbie friendliness 88/100
amponce/archive-movie-browser#166 ·