Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

Resolvers are not run on the default deletion mutation

Closed Beginner friendly
  • Is something wrong?
#5,425 7 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
78/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
graphql, php, symfony
Domain
api, backend

Research direction

Start in src/GraphQl/Resolver/Factory/ItemMutationResolverFactory.php and reproduce the issue with a GraphQL DeleteMutation that specifies a resolver and arguments. Verify that the configured resolver runs for the default deletion mutation, then run the relevant test suite to confirm the behavior.

Written by the indexing model from the issue text.

Description

GraphQL State

API Platform version(s) affected: 3.1.3

Description
With GraphQL when we try to add a resolver on the delete mutation it doesn't work. It is not executed.

How to reproduce

#[ApiResource(
    graphQlOperations: [
        new Mutation(
            resolver: CreateResolver::class,
            args: [
                'test' => [
                    'type' => 'String!',
                ]
            ],
            name: 'create'
        ),
        new DeleteMutation(
            resolver: DeleteResolver::class,
            args: [
                'id' => [
                    'type' => 'ID!',
                ],
            ],
            name: 'delete',
        )
    ]
)]

Possible Solution

In src/GraphQl/Resolver/Factory/ItemMutationResolverFactory.php If the operation is "delete" the resolver are not executed because the resolver are executed after.

if ('delete' === $operation->getName() || $operation instanceof DeleteOperationInterface) {
    ($this->securityPostDenormalizeStage)($resourceClass, $operation, $resolverContext + [
        'extra_variables' => [
            'object' => $item,
            'previous_object' => $previousItem,
        ],
    ]);
    $item = ($this->writeStage)($item, $resourceClass, $operation, $resolverContext);

    return ($this->serializeStage)($item, $resourceClass, $operation, $resolverContext);
}

$item = ($this->deserializeStage)($item, $resourceClass, $operation, $resolverContext);

$mutationResolverId = $operation->getResolver();
if (null !== $mutationResolverId) {
    /** @var MutationResolverInterface $mutationResolver */
    $mutationResolver = $this->mutationResolverLocator->get($mutationResolverId);
    $item = $mutationResolver($item, $resolverContext);
    if (null !== $item && $resourceClass !== $itemClass = $this->getObjectClass($item)) {
        throw new \LogicException(sprintf('Custom mutation resolver "%s" has to return an item of class %s but returned an item of class %s.', $mutationResolverId, $operation->getShortName(), (new \ReflectionClass($itemClass))->getShortName()));
    }
}
Dominant language
PHP
Stars
2.6k
Forks
984
Avg merge
1d 9h
Merged PRs (30d)
87

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from api-platform/core

All issues in api-platform/core

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.