Fix dark-mode table headers and phone-width overflow in the reference guide's CSS
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- css
- Domain
- documentation, frontend
Research direction
Both fixes go in css/wicket.css: add a dark-mode rule for table thead, table tfoot and tbody tr th that overrides the #f7f8f7 background from asciidoctor.css, and change the #toc.toc2 negative margin in the max-width: 767px block so it matches its container padding. Build with mvn -pl wicket-user-guide -Pguide generate-resources, then check target/generated-docs/single.html at 375 px with prefers-color-scheme: dark. Done means header text reaches 4.5:1 contrast and the page no longer scrolls sideways.
Written by the indexing model from the issue text.
Description
Two problems in the restyled reference guide (#1845), both in css/wicket.css, found while checking the accessibility chapter (#1847) in the new design.
Table header rows are unreadable in dark mode
asciidoctor.css gives table thead, table tfoot and tbody tr th the background #f7f8f7. In dark mode the header cells get the light text colour of the dark theme but keep this background, so the header row is light grey text, rgb(164, 184, 176), on an almost white background: a contrast of about 2:1, where WCAG 2.2 success criterion 1.4.3 asks for 4.5:1.
On master it shows on the one table with a header row, in "Working with AJAX" (chapter 19); #1847 adds a second one, the WCAG criteria table in "Accessibility". A dark-mode rule for table thead, table tfoot and tbody tr th that uses the page's own surface colour would fix both.
The page scrolls sideways at phone width
Below 768px, #toc.toc2 gets margin: 0 -36px (wicket.css, the max-width: 767px block). The table of contents then reaches from -18px to 393px on a 375px wide viewport, and the whole page scrolls 18px sideways (success criterion 1.4.10 asks for no scrolling in two directions at 320 CSS pixels). A negative margin that matches the padding of its container would keep the full-bleed look without the overflow.
Both were seen in target/generated-docs/single.html built with mvn -pl wicket-user-guide -Pguide generate-resources on master at 745ae018ec, in a 375 × 667 viewport and with prefers-color-scheme: dark.
- Dominant language
- Java
- Stars
- 800
- Forks
- 423
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 170
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apache/wicket
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Document and enforce pull request review guidelinesPossibly taken @dashorst claimed this 7 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
COOP and COEP exemptions compare with the context path, so page exemptions never matchPossibly taken @asvanberg claimed this 25 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
apache/wicket#1661 · 1 comment · 1 reaction ·
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
Maintainers usually reply within 1 day
-
RIS export splits an organization name containing “and” into multiple authorsPossibly taken @Gautam-aman claimed this today. Openstatus: needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
JabRef/jabref#17821 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day