The web socket setup script fails on a page without jQuery
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 88/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- javascript
Research direction
Start with wicket-native-websocket-core/wicket-websocket-setup.js.tmpl and trace the setup script used by a WebSocketBehavior on the VANILLA example page. Add the proposed test for the rendered script and verify that pages without jQuery open the connection and receive push messages without any jQuery reference.
Written by the indexing model from the issue text.
Description
The script that sets up the web socket connection, wicket-websocket-setup.js.tmpl in wicket-native-websocket-core, still calls jQuery.extend(Wicket.WebSocket, ...) to store the page id, the context, the connection token and the other settings.
Master's JavaScript no longer needs jQuery. On a page that does not load jQuery, a page with a WebSocketBehavior fails with ReferenceError: jQuery is not defined, the connection is never opened and no push message reaches the page. The examples show it when started with -Dwicket.examples.use=VANILLA.
Proposed fix: use Object.assign instead of jQuery.extend, which behaves the same for this flat object, and add a test that the rendered setup script does not refer to jQuery.
- Dominant language
- Java
- Stars
- 797
- Forks
- 416
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 43
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apache/wicket
-
COOP and COEP exemptions compare with the context path, so page exemptions never matchPossibly taken @VelpulaGangavardhan claimed this 3 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
apache/wicket#1661 · 1 comment ·
Maintainers usually reply within 1 day
-
The CSP report-uri is lost in development mode because strict() clears itPossibly taken @VelpulaGangavardhan claimed this 3 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
apache/wicket#1660 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
apache/wicket#1567 · 1 comment ·
Maintainers usually reply within 1 day
-
Quickstart: mvn jetty:run has no SLF4J back end after slf4j-simple moved to test scopePossibly taken @dashorst claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 30/100
apache/wicket#1690 · 1 comment ·
Maintainers usually reply within 1 day
-
WebSocket: Request wrappers break the Servlet header contract (case-sensitive lookup, single-use enumerations)Possibly taken @reiern70 claimed this today. Open
Difficulty 3/5 1-2 days Newbie friendliness 68/100
apache/wicket#1688 · 1 assignee ·
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
apache/rocketmq-dashboard#7250 ·
Maintainers usually reply within 3 days
-
HttpMaxFrameSizeTest.sendOversizedMessageTest() passes silently when maxFrameSize is not enforcedOpen
Difficulty 1/5 Under an hour Newbie friendliness 90/100
apache/activemq#2706 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
federicoiosue/Omni-Notes#1032 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
unitycatalog/unitycatalog#2025 ·
Maintainers usually reply within 4 days
-
Difficulty 1/5 1-3 hours Newbie friendliness 78/100
krizaka/krizaka-notifications#22 ·
Maintainers usually reply within 1 day