[Bug] IOTinyUtils.copyFile throws NullPointerException for a target file in the current directory

Open
#11,461 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

@hickey-ai is already working on this.

Since Oct 20, 2026.

  • #11464 by @hickey-ai — open
  • #11501 by @Drifter-yh — open

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
25/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
java
Domain
backend

Research direction

The issue points to IOTinyUtils.copyFile at line 84 and describes bare relative targets, nested targets, and missing sources. Read the existing IOTinyUtilsTest tests and run the native common test suite to see the current behavior. Done means regression coverage verifies copying to new and existing bare targets, nested directory creation, and preserving an existing target when the source is missing; PR #11464 is already open against this issue.

Written by the indexing model from the issue text.

Description

Before Creating the Bug Report
  • I found a bug, not just asking a question, which should be created in GitHub Discussions.

  • I have searched the GitHub Issues and GitHub Discussions of this repository and believe that this is not a duplicate.

  • I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.

Runtime platform environment

Windows 11; local file utility tests using unique temporary filenames and cleanup. No broker deployment is required.

RocketMQ version

develop, revision 5.5.1, commit 57c2dc04f78cc7e73e6b8c9436ee0fff0d0f46c3.

JDK Version

OpenJDK 1.8.0_302 (GraalVM CE 21.2.0), Maven 3.6.3.

Describe the Bug

copyFile(source, "copy.bin") constructs a File for the target and unconditionally calls tf.getParentFile().mkdirs(). A bare relative filename has no parent File, so copying fails with NullPointerException before any bytes are copied. Both new and existing target files are affected.

Steps to Reproduce
  1. Create an ordinary source file with known bytes.
  2. Call IOTinyUtils.copyFile(source.toString(), "copy-unique-name.bin") with a filename that has no directory component.
  3. Repeat with an already existing bare target filename.
  4. Remove the unique test target in finally.

Both calls fail at the getParentFile().mkdirs() line; an absolute or nested target is the control case.

What Did You Expect to See?

A bare filename is a valid target in the current working directory. New files should be copied, existing files overwritten with the source bytes, and nested target directories should still be created when present.

What Did You See Instead?

NullPointerException at IOTinyUtils.copyFile line 84, before the copy starts.

Additional Context

The minimal correction only guards the optional parent directory. Four new regression methods cover new/overwritten relative targets, nested directory creation, and preserving an existing target when the source is missing. Two bare-target cases fail before the correction; all four pass after. The independent native common run executes the 8 existing IOTinyUtilsTest tests plus the 4 new tests: 12 passed, 0 failures/errors/skips, with Checkstyle/SpotBugs passing.

#10208 and PR #10210 concern resource closure in the same method, but their diff does not change the null-parent call. PR #10733 does not modify IOTinyUtils. No matching discussion or relative-target fix was found in the reviewed results.

AI assistance: OpenAI Codex was used for investigation, implementation and tests.

Dominant language
Java
Stars
22.7k
Forks
12k
Avg merge
3d 18h
Merged PRs (30d)
17

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from apache/rocketmq

All issues in apache/rocketmq

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.