[Bug] IOTinyUtils.copyFile throws NullPointerException for a target file in the current directory

Aperta
  • Qualcosa non va?
#11,461 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@hickey-ai ci sta già lavorando.

Dal 20/10/2026.

  • #11464 di @hickey-ai — aperta
  • #11501 di @Drifter-yh — aperta

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
25/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Ferma
Stack tecnologico
java
Ambito
backend

Direzione di ricerca

The issue points to IOTinyUtils.copyFile at line 84 and describes bare relative targets, nested targets, and missing sources. Read the existing IOTinyUtilsTest tests and run the native common test suite to see the current behavior. Done means regression coverage verifies copying to new and existing bare targets, nested directory creation, and preserving an existing target when the source is missing; PR #11464 is already open against this issue.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Before Creating the Bug Report

  • I found a bug, not just asking a question, which should be created in GitHub Discussions.

  • I have searched the GitHub Issues and GitHub Discussions of this repository and believe that this is not a duplicate.

  • I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.

Runtime platform environment

Windows 11; local file utility tests using unique temporary filenames and cleanup. No broker deployment is required.

RocketMQ version

develop, revision 5.5.1, commit 57c2dc04f78cc7e73e6b8c9436ee0fff0d0f46c3.

JDK Version

OpenJDK 1.8.0_302 (GraalVM CE 21.2.0), Maven 3.6.3.

Describe the Bug

copyFile(source, "copy.bin") constructs a File for the target and unconditionally calls tf.getParentFile().mkdirs(). A bare relative filename has no parent File, so copying fails with NullPointerException before any bytes are copied. Both new and existing target files are affected.

Steps to Reproduce
  1. Create an ordinary source file with known bytes.
  2. Call IOTinyUtils.copyFile(source.toString(), "copy-unique-name.bin") with a filename that has no directory component.
  3. Repeat with an already existing bare target filename.
  4. Remove the unique test target in finally.

Both calls fail at the getParentFile().mkdirs() line; an absolute or nested target is the control case.

What Did You Expect to See?

A bare filename is a valid target in the current working directory. New files should be copied, existing files overwritten with the source bytes, and nested target directories should still be created when present.

What Did You See Instead?

NullPointerException at IOTinyUtils.copyFile line 84, before the copy starts.

Additional Context

The minimal correction only guards the optional parent directory. Four new regression methods cover new/overwritten relative targets, nested directory creation, and preserving an existing target when the source is missing. Two bare-target cases fail before the correction; all four pass after. The independent native common run executes the 8 existing IOTinyUtilsTest tests plus the 4 new tests: 12 passed, 0 failures/errors/skips, with Checkstyle/SpotBugs passing.

#10208 and PR #10210 concern resource closure in the same method, but their diff does not change the null-parent call. PR #10733 does not modify IOTinyUtils. No matching discussion or relative-target fix was found in the reviewed results.

AI assistance: OpenAI Codex was used for investigation, implementation and tests.

Lingua principale
Java
Stelle
22.7k
Fork
12k
Merge medio
3g 18h
PR unite (30g)
17

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di apache/rocketmq

Tutte le issue di apache/rocketmq

Issue simili

Altre issue su Java

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.