Bug: generator should not rely on parsed data, in particular dates
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- backend
Research direction
Start by tracing the generator methods, especially the cluster generator, and inspect where the parsed message and date enter hash construction. Compare that path with the original textual headers and date input. Done means hash inputs remain stable when parsing, date conversion, header wrapping, spacing, or validation behavior changes.
Written by the indexing model from the issue text.
Description
The generator methods currently rely on the parsed message to create the hash.
This is subject to change if the parsing should ever change.
For example, headers might be unwrapped (or wrapped), and spacing may change if the parsing library is updated.
A particular problem is that the date is currently converted into UTC by the cluster generator.
The library does not currently do much validation of the format (for example, the following date parses OK: 'Tue, 13 Jul 2004 17:09:03 -429496729500')
However if the validation is ever changed, then the date input to the hash will change. Given that the actual date is irrelevant to the hash, it should be treated the same as any other header, i.e. as textual input only.
If the parsed message is to be used for the hash, then headers need to be normalised before use.
- Dominant language
- JavaScript
- Stars
- 80
- Forks
- 32
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apache/ponymail
-
Difficulty 3/5 1-2 days Newbie friendliness 38/100
-
Difficulty 3/5 1-2 days Newbie friendliness 42/100
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
-
Difficulty 4/5 3-5 days Newbie friendliness 20/100
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
capricorn86/happy-dom#2485 ·
Maintainers usually reply within 2 days
-
area:space-accuracy good first issue track:data
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Sara-Managed-Projects/space-radar#904 ·
Maintainers usually reply within 1 day