registerTemplate / registerIso accept a 2048-character URL, but vm_template.url holds 1024

Open Beginner friendly
#14,715 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
77/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
java, sql
Domain
cloud, database

Research direction

Read RegisterTemplateCmd, RegisterIsoCmd, and VMTemplateVO, then compare their URL lengths with the vm_template.url definition and existing upgrade scripts. Follow the migration pattern in schema-41900to41910.sql and check how sibling URL columns were widened. Done means the database limit matches the accepted URL length and the upgrade script applies cleanly.

Written by the indexing model from the issue text.

Description

problem

registerTemplate and registerIso declare their url parameter with length = 2048, and VMTemplateVO maps the column with length = 2048. The column itself is VARCHAR(1024): #8675 (the fix for #8669, released in 4.19.1) widened it from 255 to 1024 in schema-41900to41910.sql, and no later upgrade script changes it.

A URL of 1025 to 2048 characters therefore passes the API's length check and fails afterwards, when the template row is written. The caller gets a generic internal error that names neither the URL nor a limit: seen in practice with a presigned URL of about 1700 characters, which came back as HTTP 530 with cserrorcode 4250. The cause given here is from reading the source.

URLs of that length are ordinary for object storage. An S3 presigned URL signed with temporary credentials (an instance role, a task role, an assumed role) carries an X-Amz-Security-Token of about a thousand characters and usually comes to 1500–1800 characters in all. The same object signed with a long-lived access key gives a URL of 500–600 characters, which registers. #8669 was this trigger at the old 255 limit.

The sibling columns were widened to 2048 back in 4.8 (schema-471to480.sql: template_store_ref.url, volume_store_ref.url, volume_store_ref.download_url, upload.url, image_store.url). vm_template.url is the one left behind.

versions

Read in the source at tags 4.20.0.0 and 4.23.0.0 and on main (2026-11-16): RegisterTemplateCmd, RegisterIsoCmd, VMTemplateVO, schema-41900to41910.sql. By the upgrade scripts, every release from 4.19.1 on has the 1024 column.

The steps to reproduce the bug
  1. Take any reachable template URL and pad its query string until the whole URL is longer than 1024 characters and shorter than 2048 (or presign an S3 object with temporary credentials).
  2. Call registerTemplate (or registerIso) with it.
  3. The call fails with a generic internal error instead of registering the template.

A URL of 1024 characters or fewer for the same object registers.

What to do about it?

Widen vm_template.url to VARCHAR(2048) in an upgrade script, so the column matches the API parameter, the VO and the sibling tables. Failing that, lower the parameter's length to 1024 so the API refuses the URL with a message that names the limit.

Dominant language
Java
Stars
3.1k
Forks
1.4k
Avg merge
7d 4h
Merged PRs (30d)
13

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from apache/cloudstack

All issues in apache/cloudstack

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.