resizeVolume of a running system VM's volume is accepted but the VM never sees the new size
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
Research direction
Start with VolumeApiServiceImpl.orchestrateResizeVolume and trace how it identifies the VM and applies the existing resize state checks. Check the related tests for size-only volume resizing and system VM states; the change is done when resizing a system VM volume is refused unless the VM is stopped, while stopped VM resizing still works.
Written by the indexing model from the issue text.
Description
problem
A size-only resizeVolume of a running system VM's volume, for example a virtual router's ROOT, is accepted and resizes the volume on the storage. The running system VM is never told, so the guest keeps seeing the old size until it next starts. The API, the database and the storage all report the new size while the VM still runs on the old one.
VolumeApiServiceImpl.orchestrateResizeVolume only looks the VM up as a user VM (_userVmDao.findById). For a system VM that returns null, so the resize is sent with the instance name none and no host. On KVM the image is grown, but virsh blockresize is never run for the running domain. The per-hypervisor checks in the same method (XenServer can only resize a stopped VM's disk; on KVM the VM's host must be Up and Enabled) are skipped for the same reason.
Other paths already treat system VM volumes differently:
- volume snapshots of system VM volumes are refused;
- attach and detach accept only user VMs;
- a ROOT resize through a new disk offering is refused unless the VM is Stopped.
The size-only path has no such check.
versions
4.22, and main.
The steps to reproduce the bug
Seen on KVM with Ceph RBD primary storage:
- Take a running virtual router whose ROOT disk offering is not size-strict.
- Call
resizeVolume id=<router ROOT volume> size=<larger size in GB>. - The call succeeds.
listVolumesandrbd infoshow the new size. - On the host,
virsh domblkinfo <router> vdastill shows the old size, and so doeslsblkin the router. The new size only appears after the router is restarted.
What to do about it?
Refuse to resize the volume of a system VM that is not Stopped, with an error telling the admin to stop it first. Resizing it while it is stopped keeps working as before, and the VM sees the new size when it starts.
Doing the resize live instead would mean running the system VM's resize through the VM work queue and notifying the hypervisor, as is done for user VMs, and checking that on each hypervisor. Refusing is the smaller, safer change.
- Dominant language
- Java
- Stars
- 3.1k
- Forks
- 1.4k
- Avg merge
- 7d 4h
- Merged PRs (30d)
- 13
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apache/cloudstack
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
apache/cloudstack#14719 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
apache/cloudstack#14715 ·
Maintainers usually reply within 1 day
-
VR reports a load balancer change as applied when haproxy.cfg cannot be replacedPossibly taken @bhouse-nexthop claimed this 7 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
apache/cloudstack#14633 · 1 comment ·
Maintainers usually reply within 1 day
-
restartNetwork reports a ResourceUnavailableException as an unexpected error (530), unlike restartVPC (534)Possibly taken @bhouse-nexthop claimed this 7 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
apache/cloudstack#14631 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
apache/cloudstack#14625 · 1 comment ·
Maintainers usually reply within 1 day
All issues in apache/cloudstack
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 75/100
SAP/ai-sdk-java#1206 ·
Maintainers usually reply within 1 day
-
enhancement good first issue insight-module
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
sdlc-pro/spring-lens#606 ·
Maintainers usually reply within 1 day
-
quality-assurance
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Paul-Austin-Oswego-CSC480-HCI521/gift-app#252 ·
Maintainers usually reply within 1 day
-
backlog kind/bug
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
TencentBlueKing/bk-job#4627 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 63/100
openrocket/openrocket#3460 ·
Maintainers usually reply within 1 day