Filter chips discard the default browser query
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 63/100
Research direction
Start with CardBrowserInitialQueryFilterTest.kt, which reproduces the issue by setting the default query to "cat" and then changing the flags filter. Trace how filter chip changes update searchRequestFlow before the search view is opened, and check the related browser search state handling. Done means changing a chip preserves the configured query; run the focused test to confirm.
Written by the indexing model from the issue text.
Description
Assisted-by: GPT-6.1-Sol xhigh
Subject: [EXISTING] Filter chips discard the default browser query
Selecting a filter chip before opening search clears the configured default query, widening the displayed results.
⚠️ This issue existed before the PR and should likely be split off into a separate issue.
---
diff --git a/AnkiDroid/src/test/java/com/ichi2/anki/browser/CardBrowserInitialQueryFilterTest.kt b/AnkiDroid/src/test/java/com/ichi2/anki/browser/CardBrowserInitialQueryFilterTest.kt
new file mode 100644
index 0000000000..6ba0e5b445
--- /dev/null
+++ b/AnkiDroid/src/test/java/com/ichi2/anki/browser/CardBrowserInitialQueryFilterTest.kt
@@ -0,0 +1,27 @@
+// SPDX-License-Identifier: GPL-3.0-or-later
+
+package com.ichi2.anki.browser
+
+import androidx.test.ext.junit.runners.AndroidJUnit4
+import com.ichi2.anki.Flag
+import com.ichi2.anki.RobolectricTest
+import com.ichi2.anki.utils.ext.defaultBrowserSearch
+import org.junit.Test
+import org.junit.runner.RunWith
+import kotlin.test.assertEquals
+
+@RunWith(AndroidJUnit4::class)
+class CardBrowserInitialQueryFilterTest : RobolectricTest() {
+ @Test
+ fun `changing a chip retains the default browser query before opening search`() {
+ col.config.defaultBrowserSearch = "cat"
+ withCardBrowserFragment(useSearchView = true) {
+ advanceRobolectricLooperUntil { activityViewModel.searchRequestFlow.value.query == "cat" }
+
+ searchViewModel.setFlagsFilter(listOf(Flag.BLUE))
+ advanceRobolectricLooperUntil { activityViewModel.searchRequestFlow.value.filters.flags == listOf(Flag.BLUE) }
+
+ assertEquals("cat", activityViewModel.searchRequestFlow.value.query)
+ }
+ }
+}
Originally posted by @david-allison in https://github.com/ankidroid/Anki-Android/pull/23355#pullrequestreview-5941465802
- Dominant language
- Kotlin
- Stars
- 12.3k
- Forks
- 3.1k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 383
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ankidroid/Anki-Android
-
Needs Triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
ankidroid/Anki-Android#23392 ·
Maintainers usually reply within 1 day
-
Needs Triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
ankidroid/Anki-Android#23390 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
ankidroid/Anki-Android#23385 · 1 reaction ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
ankidroid/Anki-Android#23374 ·
Maintainers usually reply within 1 day
-
Selected custom-study tags become unreadablePossibly taken @chesh-ire claimed this 1 day ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
ankidroid/Anki-Android#23352 · 1 comment · 1 assignee ·
Maintainers usually reply within 1 day
All issues in ankidroid/Anki-Android
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
LeanBitLab/LeanType#864 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 61/100
PixelPlayerHQ/PixelPlayerOSS#249 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
streetcomplete/StreetComplete#7395 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
134130/intellij-mise#552 ·