Search tags filter is dropped after recreation

Open
#23,198 3 comments 0 reactions 1 assignee View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
55/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
android, kotlin
Domain
mobile, testing

Research direction

The reproduction test is in AnkiDroid/src/test/java/com/ichi2/anki/browser/SearchTagsDialogRecreationTest.kt; start by running its recreation test and tracing how the Tags dialog restores its selection and updates the search filter. Done means confirming the dialog after recreation applies the selected tags, with the regression test passing.

Written by the indexing model from the issue text.

Description

Subject: [EXISTING] Search tags filter is dropped after recreation

Rotating while the search screen's Tags dialog is open, then confirming, leaves the search tags filter unchanged.

⚠️ This issue existed before the PR and should likely be split off into a separate issue.
---
diff --git a/AnkiDroid/src/test/java/com/ichi2/anki/browser/SearchTagsDialogRecreationTest.kt b/AnkiDroid/src/test/java/com/ichi2/anki/browser/SearchTagsDialogRecreationTest.kt
new file mode 100644
index 0000000000..8ddfcfc092
--- /dev/null
+++ b/AnkiDroid/src/test/java/com/ichi2/anki/browser/SearchTagsDialogRecreationTest.kt
@@ -0,0 +1,68 @@
+// SPDX-License-Identifier: GPL-3.0-or-later
+
+package com.ichi2.anki.browser
+
+import android.content.DialogInterface
+import androidx.appcompat.app.AlertDialog
+import androidx.test.core.app.ActivityScenario
+import androidx.test.ext.junit.runners.AndroidJUnit4
+import com.ichi2.anki.CardBrowser
+import com.ichi2.anki.RobolectricTest
+import com.ichi2.anki.browser.search.StandardSearchFragment
+import com.ichi2.anki.browser.search.requireChildFragment
+import com.ichi2.anki.dialogs.tags.TagsDialog
+import com.ichi2.anki.settings.Prefs
+import com.ichi2.anki.utils.ext.DIALOG_FRAGMENT_TAG
+import org.junit.Test
+import org.junit.runner.RunWith
+import kotlin.test.assertEquals
+import kotlin.test.assertIs
+import kotlin.test.assertNotNull
+
+@RunWith(AndroidJUnit4::class)
+class SearchTagsDialogRecreationTest : RobolectricTest() {
+    @Test
+    fun `search tags dialog updates search filter`() = probe(recreate = false)
+
+    @Test
+    fun `search tags dialog restored after recreation updates search filter`() = probe(recreate = true)
+
+    private fun probe(recreate: Boolean) =
+        runTest {
+            addBasicNote("Tagged").apply {
+                addTag("probe")
+                flush()
+            }
+            Prefs.devUsingCardBrowserSearchView = true
+            try {
+                ActivityScenario.launch(CardBrowser::class.java).use { scenario ->
+                    lateinit var browser: CardBrowser
+                    scenario.onActivity { browser = it }
+                    assertNotNull(browser.cardBrowserFragment.searchView).show()
+                    advanceRobolectricLooper()
+                    val standard = browser.cardBrowserFragment.requireChildFragment<StandardSearchFragment>(StandardSearchFragment.TAG)
+                    standard.viewModel.setTagsFilter(listOf("probe"))
+                    advanceRobolectricLooper()
+                    standard.binding.tagsChip.performClick()
+                    advanceRobolectricLooper()
+                    assertIs<TagsDialog>(browser.supportFragmentManager.findFragmentByTag(DIALOG_FRAGMENT_TAG))
+                    if (recreate) {
+                        scenario.recreate()
+                        advanceRobolectricLooper()
+                        scenario.onActivity { browser = it }
+                    }
+                    val vm = browser.cardBrowserFragment.searchViewModel
+                    vm.setTagsFilter(emptyList())
+                    advanceRobolectricLooper()
+                    val dialog = assertIs<TagsDialog>(browser.supportFragmentManager.findFragmentByTag(DIALOG_FRAGMENT_TAG))
+                    val button = (dialog.requireDialog() as AlertDialog).getButton(DialogInterface.BUTTON_POSITIVE)
+                    advanceRobolectricLooperUntil { button.isEnabled }
+                    button.performClick()
+                    advanceRobolectricLooper()
+                    assertEquals(listOf("probe"), vm.filtersFlow.value.tags)
+                }
+            } finally {
+                Prefs.devUsingCardBrowserSearchView = false
+            }
+        }
+}
Dominant language
Kotlin
Stars
12.3k
Forks
3.1k
Avg merge
1d 11h
Merged PRs (30d)
383

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ankidroid/Anki-Android

All issues in ankidroid/Anki-Android

Similar issues

More Kotlin issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.