Restore the skipped compat Firestore and Storage specs
Maintainers usually reply within 3 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 48/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- angular, firebase, typescript
Research direction
Start with the listed compat Firestore specs under src/compat/firestore and src/compat/storage/storage.spec.ts; inspect the top-level and individual pending calls and run the affected browser specs to identify why they were disabled. Check the Firebase SDK v11 flakes in the collection and collection-group specs as well. Done means the underlying failures are fixed, all listed specs run without pending skips, and the browser tests pass.
Written by the indexing model from the issue text.
Description
The browser test suite skips every spec for three compat Firestore classes and one compat Storage spec, so CI does not check those APIs:
src/compat/firestore/collection/collection.spec.ts,src/compat/firestore/collection-group/collection-group.spec.tsandsrc/compat/firestore/document/document.spec.tscallpending("These are pretty broken, investigate.")in their top-levelbeforeEach, which skips every spec in those files (AngularFirestoreCollection,AngularFirestoreCollectionGroup,AngularFirestoreDocument). This came in with #3586.- Inside the first two files, four more specs carry their own
pendingfor flakes with Firebase SDK v11, and will need the same look once thebeforeEachskip is gone. src/compat/storage/storage.spec.tsskips "should upload, get metadata, and delete" withpending("Not sure why this is busted.").
The compat support statement in docs/compat.md (#3810) commits to bug fixes for these APIs, so their specs should run. The work is to find out why each one was disabled, fix the spec or the code, and remove the pending calls.
- Dominant language
- TypeScript
- Stars
- 7.8k
- Forks
- 2.1k
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 25
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from angular/angularfire
-
Difficulty 2/5 1-3 hours Newbie friendliness 55/100
angular/angularfire#3800 · 1 reaction ·
Maintainers usually reply within 3 days
-
Use `TransferState` to hand server-rendered Firestore data to the browser, instead of reading every document twiceMay be free again @armando-navarro claimed this 74 days ago, and no pull request is open. Opencomp: firestore comp: ssr priority: P0 (critical) type: feature version: current (v17+)
angular/angularfire#3757 · 1 assignee ·
Maintainers usually reply within 3 days
-
Six `firebase` entry points have no `@angular/fire` equivalent, so their exports are unreachableMay be free again @armando-navarro claimed this 74 days ago, and no pull request is open. Opencomp: core type: feature
angular/angularfire#3755 · 1 assignee ·
Maintainers usually reply within 3 days
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
angular/angularfire#3737 · 4 comments · 26 reactions ·
Maintainers usually reply within 3 days
-
Difficulty 4/5 3-5 days Newbie friendliness 52/100
angular/angularfire#3715 ·
Maintainers usually reply within 3 days
All issues in angular/angularfire
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
jeanibarz/knowledge-base-mcp-server#1268 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 78/100
Koenkk/zigbee-herdsman-converters#13820 ·
Maintainers usually reply within 2 days
-
[prefer-expect-resolves] autofix leaves a stray ")" when the awaited expression is parenthesizedOpen
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
jest-community/eslint-plugin-jest#2052 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Wallet functions throws TypeError when the wallet has no account IDPossibly taken @Medhansh-741 claimed this today. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
hiero-ledger/hiero-sdk-js#4781 · 1 comment ·
Maintainers usually reply within 1 day