The `ANGULARFIRE2_VERSION` build placeholder ships unreplaced in the library, and `versions.json` never reaches the compiled schematics

Open
  • Is something wrong?
#3,715 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 3 days

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
52/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
angular, firebase, typescript
Domain
build-system, release, tooling

Research direction

Start with src/core.ts and tools/build.ts, then inspect src/schematics/versions.json and addDependencies() in src/schematics/common.ts. Compare the build-time placeholder handling in PRs #3709 and #3711 and trace when the JSON is bundled. Done means the published VERSION reports the installed version and shipped schematics contain usable dependency version data.

Written by the indexing model from the issue text.

Description

Version info

Angular: 21.2.x Firebase: 12.x AngularFire: 21.0.0-rc.0

How to reproduce these conditions
  1. npm pack @angular/fire@next and inspect fesm2022/angular-fire.mjs — search for ANGULARFIRE2_VERSION.
  2. Or in an app: import { VERSION } from '@angular/fire'; console.log(VERSION.full);
Expected behavior

VERSION.full (and the underlying Version object in src/core.ts) should report the real installed version, e.g. 21.0.0-rc.0.

Actual behavior

VERSION is constructed as new Version('ANGULARFIRE2_VERSION') - the build-time placeholder that's supposed to be replaced with the real version before publishing, but isn't for this occurrence. The published package ships the literal string.

A related mechanism is also broken: src/schematics/versions.json's peerDependencies/firebaseFunctionsDependencies data is filled in by tools/build.ts after the schematics are bundled with esbuild, which has already inlined the JSON import from the unfilled source file at compile time.

  • The post-build edit to versions.json on disk is never read by the shipped schematic code.
  • One concrete effect: addDependencies() in src/schematics/common.ts never has real version data to check against, so it can't detect or warn about conflicting dependency versions the way it appears designed to.

Will need a decision on one of these approaches:

  • string-replace with a build-time guard, matching what PR #3709/#3711 just did for the schematics' own version placeholder, or
  • reworking the versions.json inlining - the fix touches tools/build.ts and possibly src/core.ts, so I wanted to flag it and get a read before picking a direction.
Dominant language
TypeScript
Stars
7.8k
Forks
2.1k
Avg merge
2d 22h
Merged PRs (30d)
25

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from angular/angularfire

All issues in angular/angularfire

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.