[FR]: Move TopicScreen user-facing strings to resources

Open Beginner friendly
#2,115 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
86/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Quiet
Tech stack
android, kotlin
Domain
localization, mobile

Research direction

Open feature/topic/impl/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/topic/impl/TopicScreen.kt and inspect the topic feature’s existing resources and naming conventions. Move the four listed strings to resources through stringResource, then confirm the loading content description and Error, FOLLOWING, and NOT FOLLOWING labels are all resource-backed and localizable.

Written by the indexing model from the issue text.

Description

Is there an existing issue for this?
  • I have searched the existing issues
Describe the problem

TopicScreen still contains a few hardcoded user-facing strings instead of string resources:

  • NiaLoadingWheel(contentDesc = "Loading news")
  • Text("Error")
  • Text("FOLLOWING")
  • Text("NOT FOLLOWING")

These strings are rendered from feature/topic/impl/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/topic/impl/TopicScreen.kt.

Keeping them inline makes the topic screen less consistent with the rest of the app and prevents these labels and content descriptions from being localized.

This is separate from #2108 / #2109, which address the TopicUiState.Error -> TODO() crash. PR #2109 explicitly leaves these remaining TopicScreen TODOs out of scope.

Describe the solution

Move the remaining user-facing strings in TopicScreen to string resources and read them through stringResource, following the existing resource naming conventions for the topic feature.

Additional context

No response

Code of Conduct
  • I agree to follow this project Code of Conduct
Dominant language
Kotlin
Stars
21.8k
Forks
4.6k
Avg merge
19h 20m
Merged PRs (30d)
2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from android/nowinandroid

All issues in android/nowinandroid

Similar issues

More Kotlin issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.