[Bug]: Search empty-state copy reads "explorer" instead of "explore"
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 84/100
Research direction
Start with feature/search/api/src/main/res/values/strings.xml and inspect the feature_search_api_try_another_search resource. Check how SearchScreen.kt assembles it in EmptySearchResultBody, then run the existing SearchScreenTest. Done means the empty-results message uses “explore” and the test still passes.
Written by the indexing model from the issue text.
Description
Is there an existing issue for this?
- I have searched the existing issues
Is there a StackOverflow question about this issue?
- I have searched StackOverflow
What happened?
The empty-results message on the Search screen contains a grammar error. When a
search returns no results, EmptySearchResultBody renders:
Try another search or explorer Interests to browse topics
The word "explorer" (a noun) should be "explore" (a verb) to read correctly:
Try another search or explore Interests to browse topics
The faulty text comes from the feature_search_api_try_another_search string
resource:
<string name="feature_search_api_try_another_search">Try another search or explorer </string>
It is assembled into the final sentence in SearchScreen.kt
(EmptySearchResultBody), where the bold "Interests" link and " to browse topics"
are appended:
https://github.com/android/nowinandroid/blob/main/feature/search/impl/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/search/impl/SearchScreen.kt#L231-L253
This is a user-facing copy fix only and does not change app behavior. The existing
SearchScreenTest builds its expected string from the same resource, so it
continues to pass without modification.
### Relevant logcat output
```shell
Code of Conduct
- I agree to follow this project's Code of Conduct
- Dominant language
- Kotlin
- Stars
- 21.8k
- Forks
- 4.6k
- Avg merge
- 19h 20m
- Merged PRs (30d)
- 2
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from android/nowinandroid
-
documentation
Difficulty 1/5 Under an hour Newbie friendliness 92/100
android/nowinandroid#2121 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
android/nowinandroid#2115 ·
-
[Bug]: Interests top-level nav label sources string from feature/search instead of feature/interests Open
Difficulty 1/5 Under an hour Newbie friendliness 90/100
android/nowinandroid#2112 ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
android/nowinandroid#2110 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
android/nowinandroid#1984 ·
All issues in android/nowinandroid
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
bitcoindevkit/bdk-ffi#1125 ·
-
Issue: Bug
Difficulty 1/5 Under an hour Newbie friendliness 91/100
OpenAPITools/openapi-generator#24978 ·
-
helsemelding-json-schema json-schema-core
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
contributor: external needs review
Difficulty 2/5 1-3 hours Newbie friendliness 82/100