chore: remove stale dead_code allows in aimdb-cli, aimdb-mcp and the zenoh profile module
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 74/100
Research direction
Read the three locations named in the issue: tools/aimdb-cli/src/error.rs, tools/aimdb-mcp/src/server.rs, and aimdb-zenoh-connector/src/profile/mod.rs. Remove the listed suppressions and run the Makefile build and clippy feature combinations to find any remaining warnings, especially with the ros2 feature off. Done when these checks pass without broad suppressions and any necessary allowance is scoped to the affected item.
Written by the indexing model from the issue text.
Description
Problem
Three #[allow(dead_code)] suppressions have outlived their reason. They no longer hide anything today, but they will silently hide real dead code in future.
tools/aimdb-cli/src/error.rs:23—#[allow(dead_code)] // Some variants are for future useonCliError, and:141—#[allow(dead_code)] // Helper methods for future useon its constructor helpers. Every helper (connection_failed,record_not_found,write_protected,protocol_mismatch,invalid_json,server_error) has at least one caller intools/aimdb-cli/src, and the variants are constructed either through those helpers or in theFrom<ClientError>conversion.tools/aimdb-mcp/src/server.rs:103—#[allow(dead_code)]onset_state, which is called at line 119 and in the tests.aimdb-zenoh-connector/src/profile/mod.rs:8— a module-wide#[allow(dead_code, unused_imports)]with the comment "Used by the ROS 2 connector, which builds on this module".ros2.rsnow exists and uses most of the module (Attachment,Durability,EntityKind,History,Node,Qos,Reliability,validate_*,data_key,entity_token,node_token,gid).
Suggested work
- Remove the three allows and build/clippy with the feature combinations the Makefile uses.
- For anything that then warns (most likely in the zenoh
profilemodule when theros2feature is off), either delete it or scope a narrow#[cfg_attr(not(feature = "…"), allow(dead_code))]to that item instead of the whole module.
Notes
Usage was checked by grep at d9c7be0, not by compiling without the allows, so a few items may still warn under some feature combinations.
- Dominant language
- Rust
- Stars
- 101
- Forks
- 20
- Avg merge
- 2h 33m
- Merged PRs (30d)
- 90
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from aimdb-dev/aimdb
-
documentation
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 35/100
Maintainers usually reply within 1 day
-
dependencies
Difficulty 4/5 3-5 days Newbie friendliness 44/100
Maintainers usually reply within 1 day
Similar issues
-
Panic on live viewport resize when unstyled elements exist in display: none subtreePossibly taken @GoCoder7 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
DioxusLabs/blitz#1488 ·
Maintainers usually reply within 1 day
-
S-Needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
vectordotdev/vrl#2042 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day