[aem] code-assessment outbound-call-timeouts: HttpClients.createSystem() and createMinimal() are not detected
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 88/100
Research direction
Start with plugins/aem/cloud-service/skills/code-assessment/scripts/analyzer/detectors/OutboundCallTimeouts.java and inspect how CREATION_MARKERS are checked and how its existing tests build fixtures. Add coverage for HttpClients.createSystem() and createMinimal() while preserving the enclosing-scope timeout suppression. Done when both clients without timeout configuration are detected and the existing suppression behavior still passes.
Written by the indexing model from the issue text.
Description
The outbound-call-timeouts detector (plugins/aem/cloud-service/skills/code-assessment/scripts/analyzer/detectors/OutboundCallTimeouts.java, checked at 0044687) treats a client as constructed only when the text contains one of CREATION_MARKERS: .createDefault, .newBuilder, .newHttpClient, .build(, new HttpClientBuilder, new OkHttpClient. Apache HttpClient 4.x HttpClients.createSystem() and HttpClients.createMinimal() match none of them, so a client built with either is never flagged.
createSystem() matters on AEM as a Cloud Service: it honours the proxy system properties, so teams use it for the dedicated egress IP, yet in 4.x it sets no connect or socket timeout. In a November 2026 review, a createSystem() client with no RequestConfig was not reported.
Suggested fix: add .createSystem and .createMinimal to CREATION_MARKERS, with a test fixture for each. The existing suppression (any timeout token in the enclosing scope) still applies.
AI-assisted, filed on my behalf.
- Dominant language
- JavaScript
- Stars
- 324
- Forks
- 99
- Avg merge
- 2d 7h
- Merged PRs (30d)
- 121
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from adobe/skills
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
Similar issues
-
nip27: long hashtag swallows the rest of the content, lone # gives an empty hashtagPossibly taken @bardrop claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
nbd-wtf/nostr-tools#578 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
h5bp/html5-boilerplate#3512 ·
-
documentation
Difficulty 1/5 1-3 hours Newbie friendliness 85/100
githubnext/gh-aw-workshop#5752 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 70/100
Maintainers usually reply within 1 day