repo-modernize: Maven verifier reports success for unclassified build failures
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 68/100
Research direction
Start in skills/repo-modernize/scripts/verify.py at the final fallback that returns 0 when Maven fails without a recognized analyser, POM-model or legacy-code marker, and at verify.main where the captured Maven output should be printed. Reproduce by feeding Maven results with returncode 1 and the unresolved-dependency error line for both builds; the run currently exits 0. Done when that case exits nonzero, prints the captured output, and a regression test covering it passes.
Written by the indexing model from the issue text.
Description
In skills/repo-modernize/scripts/verify.py, the final fallback returns 0 when Maven fails without a recognized analyser, POM-model, or legacy-code marker. Reproduced by supplying Maven results with returncode 1 and '[ERROR] Could not resolve dependencies for project com.example:ui.apps:content-package:1.0' for both builds: verify.main returns 0. The captured Maven output is also omitted despite the message directing users to inspect it above. Return a nonzero status for unclassified failures, print the relevant diagnostics, and add a regression test. This behavior predates the latest PR #401 review fixes.
From codex's review of adobe/skills#401.
- Dominant language
- JavaScript
- Stars
- 324
- Forks
- 99
- Avg merge
- 2d 7h
- Merged PRs (30d)
- 121
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from adobe/skills
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
content-driven-development Option C still describes find-test-content as an automated search toolOpen
Difficulty 1/5 Under an hour Newbie friendliness 82/100
Maintainers usually reply within 1 day
Similar issues
-
nip27: long hashtag swallows the rest of the content, lone # gives an empty hashtagPossibly taken @bardrop claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
nbd-wtf/nostr-tools#578 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
h5bp/html5-boilerplate#3512 ·
-
documentation
Difficulty 1/5 1-3 hours Newbie friendliness 85/100
githubnext/gh-aw-workshop#5752 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 70/100
Maintainers usually reply within 1 day