Expand PackageDelivery to cover composed delivery-metrics schema
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 48/100
Research direction
Read the PackageDelivery definition and the get_media_buy_delivery.by_package[] schema composition, especially core/delivery-metrics.json. Extend or align the Go type with the legal composed fields while keeping spend required, then add drift coverage for the composed row. The payload does not name the relevant source or test files, so locate those definitions in the repository first.
Written by the indexing model from the issue text.
Description
Problem
PackageDelivery now emits the correct flat package-level wire shape, but the typed Go struct covers only a small subset of the schema.
get_media_buy_delivery.by_package[] composes core/delivery-metrics.json plus package-specific fields. Legal fields include more than impressions, spend, and clicks; examples called out by expert review include ctr, views, conversions, pacing_index, paused, measurement_window, by_creative, and other breakdown fields.
The current SDK cannot express most legal package-level delivery payloads without falling back to untyped extension patterns.
Desired outcome
- Generate or hand-align
PackageDeliverywith the full composed schema. - Preserve
spendas schema-required at package level. - Add drift coverage for the allOf-composed package delivery row.
Related
- Generator replacement/evaluation: #145
- Dominant language
- Go
- Stars
- 4
- Forks
- 2
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 26
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from adcontextprotocol/adcp-go
-
CreativeInput carries no revision_id or localization (follow-up to #545)Possibly taken @sujanchalla0510 claimed this 14 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
adcontextprotocol/adcp-go#567 ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
adcontextprotocol/adcp-go#600 ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 38/100
adcontextprotocol/adcp-go#597 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
adcontextprotocol/adcp-go#590 ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 30/100
adcontextprotocol/adcp-go#588 · 3 comments ·
Maintainers usually reply within 1 day
All issues in adcontextprotocol/adcp-go
Similar issues
-
go good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
area: api bug severity:low
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
-
raised-by:desk to:worker
Difficulty 1/5 Under an hour Newbie friendliness 74/100
medici-finance/assay#5167 ·
Maintainers usually reply within 1 day
-
Response matcher: a changed integer above 2^53 passes because JSON numbers are compared as float64Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day