Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

bug: market switcher search reports "No markets found" for legacy markets

Open Beginner friendly
  • Is something wrong?
#3,127 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

@shivam-V8 is already working on this.

Since Oct 11, 2026.

  • #3129 by @shivam-V8 — open

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
82/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
typescript
Domain
frontend

Research direction

The problem sits in src/components/MarketSwitcher.tsx: the noResults computation around lines 614-620 leaves out legacy, and the legacy group only renders when showLegacy is on (around lines 707-712). Start by reproducing a search for a legacy market such as Gnosis with the switch off, then decide whether legacy matches should show during an active query or just count toward the empty-state check. Done means a query matching only a legacy market no longer shows "No markets found", and the user can see the match or is told to turn on "Show legacy markets".

Written by the indexing model from the issue text.

Description

Describe the bug

Searching for a legacy market in the market switcher renders "No markets found", even though the market exists and matches the query. Affects every market in the legacy category — Gnosis, Sonic, Scroll, Metis, ZKsync, Soneium, EtherFi — on any market/network.

The search filter itself works: the match is computed and lands in the legacy group. Two things then hide it:

  1. The legacy group is only rendered when the "Show legacy markets" switch is on (src/components/MarketSwitcher.tsx:707-712).
  2. noResults (src/components/MarketSwitcher.tsx:614-620) counts pinned, ethereum, l2, other, v4Ethereum and v4Other — but not legacy.

So when a query matches only legacy markets, every counted group is empty, noResults is true, and the empty state renders on top of a match that was found but not displayed.

// src/components/MarketSwitcher.tsx:614
const noResults =
  pinned.length === 0 &&
  ethereum.length === 0 &&
  l2.length === 0 &&
  other.length === 0 &&
  v4Ethereum.length === 0 &&
  v4Other.length === 0;   // legacy.length is never considered

This became user-visible for Gnosis and Sonic when #3111 moved them into the legacy category (MarketSwitcher.tsx:158-159); the showLegacy switch itself arrived with the v3 uplift (#3075).

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://app.aave.com (any market)
  2. Open the market switcher in the header
  3. Leave "Show legacy markets" off (its default on every page load)
  4. Type Gnosis into the search box
  5. See "No markets found", although Gnosis exists and is selectable

Expected behavior

An explicit search should surface a matching market. Either show legacy matches whenever a search query is active, or at minimum stop reporting "No markets found" when legacy has matches — for example by including legacy.length in noResults and telling the user the matches are under "Show legacy markets".

Screenshots

n/a — reproducible from the source as described above.

Desktop (please complete the following information):

  • OS: any
  • Browser: any (not browser-specific)
  • Version: main @ 32cc548b9

Smartphone (please complete the following information):

  • Device: any
  • OS: any
  • Browser: any (the same code path renders the mobile sheet)
  • Version: main @ 32cc548b9

Additional context

Users holding positions in a legacy market are the ones most likely to search for it by name, so the empty-state message lands exactly on the people who need the market most. Happy to open a PR for this.

Dominant language
TypeScript
Stars
537
Forks
495
Avg merge
1d 13h
Merged PRs (30d)
14

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from aave/interface

All issues in aave/interface

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.