Only look for address in wider distance if not found at first try

Open
#6 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Domain
api

Research direction

Find the code that calls geocode.arcgis.com and read how it uses the distance=10000 parameter. Check the API responses for the coordinates in the linked private post if you have access, then verify that the wider-distance request happens only when the initial request returns no result.

Written by the indexing model from the issue text.

Description

As we discussed:
Living close to the border, Atlas gives the wrong address for my home location. It seems to be a problem with the &distance=10000 parameter on the API call to geocode.arcgis.com.

This was originally used to get a location in area's where there was no address found, extending the search area by 10km.

The solution would be to first make a request without the parameter, and only if it returns empty, fetch with the 10km distance param.

You can check the API-calls with coordinates for my home address in this private post, if you need testing.

Dominant language
CSS
Stars
26
Forks
3
PR merge metrics
No merged PRs in 30d

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from aaronpk/Atlas

All issues in aaronpk/Atlas

Similar issues

More Backend & API Design issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.