Not compatible with PHP 8
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 30/100
Research direction
Start with the stack trace at vendor/saltybeagle/savant3/Savant3.php:901 and follow the calls through vendor/p3k/slim-savant/Savant.php and app/controllers/main.php. Run the application on PHP 8 and check the reported dependency error and other PHP 8 incompatibilities in the app or its dependencies. Done means the application runs on PHP 8 without these compatibility failures.
Written by the indexing model from the issue text.
Description
Possibly an issue with Savant3 dependency not being compatible with PHP 8. Running the application produces this error:
Fatal error: Uncaught ValueError: func_get_arg(): Argument #1 ($position) must be less than the number of the arguments passed to the currently executed function in
/app/vendor/saltybeagle/savant3/Savant3.php:901
Stack trace:
#0 /app/vendor/saltybeagle/savant3/Savant3.php(901): func_get_arg(1)
#1 /app/vendor/p3k/slim-savant/Savant.php(74): Savant3->assign(Array)
#2 /app/vendor/slim/slim/Slim/View.php(255): Slim\Extras\Views\Savant->render('layout.php', Array)
#3 /app/vendor/slim/slim/Slim/View.php(243): Slim\View->fetch('layout.php', NULL)
#4 /app/vendor/slim/slim/Slim/Slim.php(755): Slim\View->display('layout.php')
#5 /app/vendor/p3k/slim-savant/SlimSavant.php(19): Slim\Slim->render('layout.php', Array)
#6 /app/controllers/main.php(5): Slim\Savant\render('index')
#7 [internal function]: {closure}()
#8 /app/vendor/slim/slim/Slim/Route.php(468): call_user_func_array(Object(Closure), Array)
#9 /app/vendor/slim/slim/Slim/Slim.php(1355): Slim\Route->dispatch()
#10 /app/vendor/slim/slim/Slim/Middleware/Flash.php(85): Slim\Slim->call()
#11 /app/vendor/slim/slim/Slim/Middleware/MethodOverride.php(92): Slim\Middleware\Flash->call()
#12 /app/vendor/slim/slim/Slim/Middleware/PrettyExceptions.php(67): Slim\Middleware\MethodOverride->call()
#13 /app/vendor/slim/slim/Slim/Slim.php(1300): Slim\Middleware\PrettyExceptions->call()
#14 /app/public/index.php(12): Slim\Slim->run()
#15 {main} thrown in /app/vendor/saltybeagle/savant3/Savant3.php on line 901
There may be other such incompatibility issues lurking in dependencies or in the apps own code.
PHP 7.x is no longer maintained and has reached end of life. One way this manifests itself is that versions below v8 are disabled in Brew, and not supported by tools like Nixpicks.
- Dominant language
- CSS
- Stars
- 26
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from aaronpk/Atlas
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 30/100
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
Similar issues
-
module/jwt Type/Bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
ballerina-platform/ballerina-library#9710 ·
Maintainers usually reply within 1 day
-
[BUG] Hermes MCP adapter drops cwd, extra passthrough keys and the SSE transport when writing config.yamlPossibly taken @Parth-Vasave claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
microsoft/apm#3749 · 1 comment ·
Maintainers usually reply within 1 day
-
backend bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 5 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
omdsh-dev/DSH-better-sidebar#1205 ·
Maintainers usually reply within 3 days